Re: [Qemu-devel] [PATCH v3 43/44] nbd: Implement NBD_OPT_BLOCK_SIZE on server

2016-04-25 Thread Alex Bligh
Eric, See my message on nbd-general today re the necessity (or not) of getting NBD_OPT_BLOCK_SIZE first; it may be just that you can assume 512 is OK. Otherwise Reviewed-by: Alex Bligh Alex On 23 Apr 2016, at 00:40, Eric Blake wrote: > The upstream NBD Protocol has defined a new extension t

[Qemu-devel] [PATCH v3 43/44] nbd: Implement NBD_OPT_BLOCK_SIZE on server

2016-04-22 Thread Eric Blake
The upstream NBD Protocol has defined a new extension to allow the server to advertise block sizes to the client, as well as a way for the client to inform the server that it intends to obey block sizes. Thanks to a recent fix, our minimum transfer size is always 1 (the block layer takes care of r