Re: [Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-04 Thread Laszlo Ersek
On 11/03/15 23:03, Gabriel L. Somlo wrote: > On Tue, Nov 03, 2015 at 10:35:36PM +0100, Laszlo Ersek wrote: >> On 11/03/15 18:55, Gabriel L. Somlo wrote: >>> On Tue, Nov 03, 2015 at 11:53:55AM +0100, Laszlo Ersek wrote: Thank you for splitting out this patch; it makes it easier to review.

Re: [Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-03 Thread Gabriel L. Somlo
On Tue, Nov 03, 2015 at 10:35:36PM +0100, Laszlo Ersek wrote: > On 11/03/15 18:55, Gabriel L. Somlo wrote: > > On Tue, Nov 03, 2015 at 11:53:55AM +0100, Laszlo Ersek wrote: > >> Thank you for splitting out this patch; it makes it easier to review. > >> However, > >> > >> On 11/03/15 01:35, Gabriel

Re: [Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-03 Thread Gabriel L. Somlo
On Tue, Nov 03, 2015 at 10:35:36PM +0100, Laszlo Ersek wrote: > On 11/03/15 18:55, Gabriel L. Somlo wrote: > > On Tue, Nov 03, 2015 at 11:53:55AM +0100, Laszlo Ersek wrote: > >> Thank you for splitting out this patch; it makes it easier to review. > >> However, > >> > >> On 11/03/15 01:35, Gabriel

Re: [Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-03 Thread Laszlo Ersek
On 11/03/15 18:55, Gabriel L. Somlo wrote: > On Tue, Nov 03, 2015 at 11:53:55AM +0100, Laszlo Ersek wrote: >> Thank you for splitting out this patch; it makes it easier to review. >> However, >> >> On 11/03/15 01:35, Gabriel L. Somlo wrote: >>> Introduce fw_cfg_data_read(), a generic read method wh

Re: [Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-03 Thread Gabriel L. Somlo
On Tue, Nov 03, 2015 at 11:53:55AM +0100, Laszlo Ersek wrote: > Thank you for splitting out this patch; it makes it easier to review. > However, > > On 11/03/15 01:35, Gabriel L. Somlo wrote: > > Introduce fw_cfg_data_read(), a generic read method which works > > on all access widths (1 through 8

Re: [Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-03 Thread Laszlo Ersek
Thank you for splitting out this patch; it makes it easier to review. However, On 11/03/15 01:35, Gabriel L. Somlo wrote: > Introduce fw_cfg_data_read(), a generic read method which works > on all access widths (1 through 8 bytes, inclusive), and can be > used during both IOPort and MMIO read acce

[Qemu-devel] [PATCH v3 4/5] fw_cfg: add generic non-DMA read method

2015-11-02 Thread Gabriel L. Somlo
Introduce fw_cfg_data_read(), a generic read method which works on all access widths (1 through 8 bytes, inclusive), and can be used during both IOPort and MMIO read accesses. To maintain legibility, only fw_cfg_data_mem_read() (the MMIO data read method) is replaced by this patch. The new method