Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Anthony Liguori
Peter Maydell writes: > On 22 July 2013 16:25, Anthony Liguori wrote: >> Andreas Färber writes: >>> Am 22.07.2013 13:34, schrieb Peter Maydell: Looking at all of the '-cpu help' output, alpha seems to be the odd one out here: none of the others list valid CPUs with "-$arch-cpu" s

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Anthony Liguori
Andreas Färber writes: > Am 22.07.2013 13:34, schrieb Peter Maydell: >> On 22 July 2013 12:17, Andreas Färber wrote: >>> Am 22.07.2013 12:40, schrieb Peter Maydell: In any case we should be consistent across target architectures about what we allow. >>> >>> alpha allows both > [...] >>

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 16:25, Anthony Liguori wrote: > Andreas Färber writes: >> Am 22.07.2013 13:34, schrieb Peter Maydell: >>> Looking at all of the '-cpu help' output, alpha seems to be >>> the odd one out here: none of the others list valid CPUs >>> with "-$arch-cpu" suffixes. >> >> Right, because a

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Andreas Färber
Am 22.07.2013 13:34, schrieb Peter Maydell: > On 22 July 2013 12:17, Andreas Färber wrote: >> Am 22.07.2013 12:40, schrieb Peter Maydell: >>> In any case we should be >>> consistent across target architectures about what we allow. >> >> alpha allows both [...] >> It didn't have -cpu ? before QOM,

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 12:17, Andreas Färber wrote: > Am 22.07.2013 12:40, schrieb Peter Maydell: >> Yep; my view is that the acceptance of the -or32-cpu varieties >> was a bug which we have now fixed. In any case we should be >> consistent across target architectures about what we allow. >> I'm happy wi

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Andreas Färber
Am 22.07.2013 12:40, schrieb Peter Maydell: > On 22 July 2013 11:37, Andreas Färber wrote: >> Am 22.07.2013 11:43, schrieb Peter Maydell: commit 071b3364e fix the typename only, but this one make "-cpu any" "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine. >>> >>> Th

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 11:37, Andreas Färber wrote: > Am 22.07.2013 11:43, schrieb Peter Maydell: >>> commit 071b3364e fix the typename only, but this one make "-cpu any" >>> "-cpu or1200" "-cpu any-or32-cpu" "-cpu or1200-or32-cpu" working fine. >> >> The last two of these would be wrong: -cpu should onl

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Andreas Färber
Am 22.07.2013 11:43, schrieb Peter Maydell: > On 22 July 2013 10:42, Jia Liu wrote: >> Hi Andreas and Peter, >> >> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell >> wrote: >>> This looks a bit odd. The commit message suggests it's an >>> attempt to fix the bug that was fixed by commit 071b3364e

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
On Mon, Jul 22, 2013 at 5:43 PM, Peter Maydell wrote: > On 22 July 2013 10:42, Jia Liu wrote: >> Hi Andreas and Peter, >> >> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell >> wrote: >>> This looks a bit odd. The commit message suggests it's an >>> attempt to fix the bug that was fixed by commit

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
On Mon, Jul 22, 2013 at 5:43 PM, Peter Maydell wrote: > On 22 July 2013 10:42, Jia Liu wrote: >> Hi Andreas and Peter, >> >> On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell >> wrote: >>> This looks a bit odd. The commit message suggests it's an >>> attempt to fix the bug that was fixed by commit

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 10:42, Jia Liu wrote: > Hi Andreas and Peter, > > On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell > wrote: >> This looks a bit odd. The commit message suggests it's an >> attempt to fix the bug that was fixed by commit 071b3364e -- >> is it really needed? Andreas? > > commit 071b3

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
Hi Andreas and Peter, On Mon, Jul 22, 2013 at 5:29 PM, Peter Maydell wrote: > On 22 July 2013 09:56, Jia Liu wrote: >> Fix cpu_model by name, make any and or1200 works both OK. >> >> Signed-off-by: Jia Liu >> --- >> target-openrisc/cpu.c | 16 >> 1 file changed, 12 insertions(

Re: [Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Peter Maydell
On 22 July 2013 09:56, Jia Liu wrote: > Fix cpu_model by name, make any and or1200 works both OK. > > Signed-off-by: Jia Liu > --- > target-openrisc/cpu.c | 16 > 1 file changed, 12 insertions(+), 4 deletions(-) > > diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c > in

[Qemu-devel] [PATCH v3 4/4] target-openrisc: Fix cpu_model by name

2013-07-22 Thread Jia Liu
Fix cpu_model by name, make any and or1200 works both OK. Signed-off-by: Jia Liu --- target-openrisc/cpu.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index e348df0..6637166 100644 --- a/target-openrisc/cpu.c