Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 03:19:28PM +0100, Jes Sorensen wrote: > On 03/17/11 11:45, Alon Levy wrote: > > On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote: > >> On 03/17/11 11:27, Alon Levy wrote: > >>> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > > Same for the ass

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Jes Sorensen
On 03/17/11 11:45, Alon Levy wrote: > On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote: >> On 03/17/11 11:27, Alon Levy wrote: >>> On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > Same for the asserts below, writes are from spice server thread, reads > are in ioth

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 11:29:03AM +0100, Jes Sorensen wrote: > On 03/17/11 11:27, Alon Levy wrote: > > On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > >>> Same for the asserts below, writes are from spice server thread, reads > >>> are in iothread. > >> > >> But shouldn't this make

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Jes Sorensen
On 03/17/11 11:27, Alon Levy wrote: > On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: >>> Same for the asserts below, writes are from spice server thread, reads >>> are in iothread. >> >> But shouldn't this make it try to reconnect? Even if the reconnect >> fails, it shouldn't kill th

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Thu, Mar 17, 2011 at 10:48:43AM +0100, Jes Sorensen wrote: > On 03/17/11 10:32, Alon Levy wrote: > > On Wed, Mar 16, 2011 at 05:48:41PM +0100, Jes Sorensen wrote: > >> > On 03/16/11 16:52, Alon Levy wrote: > >>> > > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, > >>> > >

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Jes Sorensen
On 03/17/11 10:32, Alon Levy wrote: > On Wed, Mar 16, 2011 at 05:48:41PM +0100, Jes Sorensen wrote: >> > On 03/16/11 16:52, Alon Levy wrote: >>> > > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, >>> > > int x, int y) >>> > > +{ >>> > > +QXLServerCursorSetRequest req; >>

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-17 Thread Alon Levy
On Wed, Mar 16, 2011 at 05:48:41PM +0100, Jes Sorensen wrote: > On 03/16/11 16:52, Alon Levy wrote: > > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, int > > x, int y) > > +{ > > +QXLServerCursorSetRequest req; > > +int r; > > + > > +req.req = QXL_SERVER_CURSOR_

Re: [Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-16 Thread Jes Sorensen
On 03/16/11 16:52, Alon Levy wrote: > +void qxl_server_request_cursor_set(PCIQXLDevice *qxl, QEMUCursor *c, int x, > int y) > +{ > +QXLServerCursorSetRequest req; > +int r; > + > +req.req = QXL_SERVER_CURSOR_SET; > +req.data.c = c; > +req.data.x = x; > +req.data.y = y; > +

[Qemu-devel] [PATCH v3 4/4] hw/qxl-render: drop cursor locks, replace with pipe

2011-03-16 Thread Alon Levy
Switching locking protection of ds->cursor_set/cursor_move to moving every call to these functions into the iothread and using the ssd->pipe to transfer that, adding QXL_SERVER_CURSOR_SET, QXL_SERVER_CURSOR_MOVE. This is tested with both -vnc :0 -spice and -sdl -spice. --- hw/qxl-render.c|