Re: [Qemu-devel] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions

2018-04-17 Thread Philippe Mathieu-Daudé
Hi Stefan, On 04/16/2018 02:23 AM, Stefan Weil wrote: > Am 16.04.2018 um 01:42 schrieb Philippe Mathieu-Daudé: >> It eases code review, unit is explicit. >> >> Patch generated using: >> >> $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ >> >> and modified manually. >> >

Re: [Qemu-devel] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions

2018-04-15 Thread Stefan Weil
Am 16.04.2018 um 01:42 schrieb Philippe Mathieu-Daudé: > It eases code review, unit is explicit. > > Patch generated using: > > $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ > > and modified manually. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/hw/n

[Qemu-devel] [PATCH v3 33/41] hw/net: Use the BYTE-based definitions

2018-04-15 Thread Philippe Mathieu-Daudé
It eases code review, unit is explicit. Patch generated using: $ git grep -E '(1024|2048|4096|8192|(<<|>>).?(10|20|30))' hw/ include/hw/ and modified manually. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/net/allwinner_emac.h | 5 +++-- hw/net/e1000e.c | 7 --- h