Re: [Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2

2015-06-04 Thread Aurelien Jarno
On 2015-06-04 12:54, Paolo Bonzini wrote: > > > On 04/06/2015 07:03, Richard Henderson wrote: > >> +tcg_gen_add2_i32(t1, t2, REG(B11_8), t0, REG(B7_4), t0); > >> +tcg_gen_add2_i32(REG(B11_8), cpu_sr_t, t1, t2, cpu_sr_t, > >> t0); > > > > Swap these two adds and you don't

Re: [Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2

2015-06-04 Thread Paolo Bonzini
On 04/06/2015 07:03, Richard Henderson wrote: >> +tcg_gen_add2_i32(t1, t2, REG(B11_8), t0, REG(B7_4), t0); >> +tcg_gen_add2_i32(REG(B11_8), cpu_sr_t, t1, t2, cpu_sr_t, >> t0); > > Swap these two adds and you don't need t2. You can consume sr_t > immediately and start pro

Re: [Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2

2015-06-03 Thread Richard Henderson
On 05/24/2015 04:37 PM, Aurelien Jarno wrote: -TCGv t0, t1; -t0 = tcg_temp_new(); +TCGv t0, t1, t2; +t0 = tcg_const_tl(0); t1 = tcg_temp_new(); -tcg_gen_add_i32(t0, REG(B7_4), REG(B11_8)); -tcg_gen_add_i32(t1, c

[Qemu-devel] [PATCH v3 3/8] target-sh4: optimize addc using add2

2015-05-24 Thread Aurelien Jarno
Signed-off-by: Aurelien Jarno --- target-sh4/translate.c | 14 ++ 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/target-sh4/translate.c b/target-sh4/translate.c index f9bc24c..a7a8f39 100644 --- a/target-sh4/translate.c +++ b/target-sh4/translate.c @@ -642,17 +642,15 @@