Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Amos Kong
- Original Message - > On 09/24/2012 11:48 AM, Amos Kong wrote: > > On 23/09/12 14:34, Orit Wasserman wrote: > >> On 09/20/2012 06:16 PM, Amos Kong wrote: > >>> - Original Message - > On 09/19/2012 11:31 AM, Amos Kong wrote: > > On 14/09/12 02:58, Orit Wasserman wrote: > >>

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Orit Wasserman
On 09/24/2012 11:48 AM, Amos Kong wrote: > On 23/09/12 14:34, Orit Wasserman wrote: >> On 09/20/2012 06:16 PM, Amos Kong wrote: >>> - Original Message - On 09/19/2012 11:31 AM, Amos Kong wrote: > On 14/09/12 02:58, Orit Wasserman wrote: >> getaddrinfo can give us a list of addr

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-24 Thread Amos Kong
On 23/09/12 14:34, Orit Wasserman wrote: On 09/20/2012 06:16 PM, Amos Kong wrote: - Original Message - On 09/19/2012 11:31 AM, Amos Kong wrote: On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fa

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-23 Thread Orit Wasserman
On 09/21/2012 11:03 AM, Markus Armbruster wrote: > Orit Wasserman writes: > >> On 09/20/2012 04:14 PM, Markus Armbruster wrote: >>> Orit Wasserman writes: >>> getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to >>>

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-22 Thread Orit Wasserman
On 09/20/2012 06:16 PM, Amos Kong wrote: > - Original Message - >> On 09/19/2012 11:31 AM, Amos Kong wrote: >>> On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-21 Thread Markus Armbruster
Orit Wasserman writes: > On 09/20/2012 04:14 PM, Markus Armbruster wrote: >> Orit Wasserman writes: >> >>> getaddrinfo can give us a list of addresses, but we only try to >>> connect to the first one. If that fails we never proceed to >>> the next one. This is common on desktop setups that oft

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Amos Kong
- Original Message - > On 09/19/2012 11:31 AM, Amos Kong wrote: > > On 14/09/12 02:58, Orit Wasserman wrote: > >> getaddrinfo can give us a list of addresses, but we only try to > >> connect to the first one. If that fails we never proceed to > >> the next one. This is common on desktop se

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/20/2012 04:14 PM, Markus Armbruster wrote: > Orit Wasserman writes: > >> getaddrinfo can give us a list of addresses, but we only try to >> connect to the first one. If that fails we never proceed to >> the next one. This is common on desktop setups that often have ipv6 >> configured but n

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Markus Armbruster
Orit Wasserman writes: > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > > To fix this make inet_connect_no

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/19/2012 11:31 AM, Amos Kong wrote: > On 14/09/12 02:58, Orit Wasserman wrote: >> getaddrinfo can give us a list of addresses, but we only try to >> connect to the first one. If that fails we never proceed to >> the next one. This is common on desktop setups that often have ipv6 >> configured

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/20/2012 12:37 PM, Michael S. Tsirkin wrote: > On Thu, Sep 20, 2012 at 11:57:37AM +0300, Orit Wasserman wrote: >> On 09/20/2012 09:03 AM, Michael S. Tsirkin wrote: @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) return sock; } - -int

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Michael S. Tsirkin
On Thu, Sep 20, 2012 at 11:57:37AM +0300, Orit Wasserman wrote: > On 09/20/2012 09:03 AM, Michael S. Tsirkin wrote: > >> @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) > >> return sock; > >> } > >> > >> - > >> -int inet_nonblocking_connect(const char *str, bool *in_pr

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-20 Thread Orit Wasserman
On 09/20/2012 09:03 AM, Michael S. Tsirkin wrote: >> @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) >> return sock; >> } >> >> - >> -int inet_nonblocking_connect(const char *str, bool *in_progress, >> - Error **errp) >> +int inet_nonblockin

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-19 Thread Michael S. Tsirkin
> @@ -526,16 +592,19 @@ int inet_connect(const char *str, Error **errp) > return sock; > } > > - > -int inet_nonblocking_connect(const char *str, bool *in_progress, > - Error **errp) > +int inet_nonblocking_connect(const char *str, ConnectHandler *callback, > +

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-19 Thread Amos Kong
On 14/09/12 02:58, Orit Wasserman wrote: getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_con

Re: [Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-14 Thread Juan Quintela
Orit Wasserman wrote: > getaddrinfo can give us a list of addresses, but we only try to > connect to the first one. If that fails we never proceed to > the next one. This is common on desktop setups that often have ipv6 > configured but not actually working. > > To fix this make inet_connect_nonb

[Qemu-devel] [PATCH v3 3/3] Fix address handling in inet_nonblocking_connect

2012-09-13 Thread Orit Wasserman
getaddrinfo can give us a list of addresses, but we only try to connect to the first one. If that fails we never proceed to the next one. This is common on desktop setups that often have ipv6 configured but not actually working. To fix this make inet_connect_nonblocking retry connection with a di