Re: [Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine

2013-10-31 Thread Eduardo Habkost
On Thu, Oct 31, 2013 at 06:51:50AM +0100, Markus Armbruster wrote: > Michael Tsirkin doesn't trust us to keep values of QEMUMachine member > product stable in the future. Use copies instead, and in a way that > makes it obvious that they're guest ABI. > > Note that we can be trusted to keep value

Re: [Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine

2013-10-30 Thread Michael S. Tsirkin
On Thu, Oct 31, 2013 at 06:51:50AM +0100, Markus Armbruster wrote: > Michael Tsirkin doesn't trust us to keep values of QEMUMachine member > product stable in the future. Use copies instead, and in a way that > makes it obvious that they're guest ABI. > > Note that we can be trusted to keep value

[Qemu-devel] [PATCH v3 3/2] smbios: Decouple system product from QEMUMachine

2013-10-30 Thread Markus Armbruster
Michael Tsirkin doesn't trust us to keep values of QEMUMachine member product stable in the future. Use copies instead, and in a way that makes it obvious that they're guest ABI. Note that we can be trusted to keep values of member name, because that has always been ABI. Signed-off-by: Markus Ar