Re: [Qemu-devel] [PATCH v3 29/39] sun4u: convert to memory API

2011-08-07 Thread Avi Kivity
On 08/05/2011 06:30 PM, Anthony Liguori wrote: -isa_bus_new(&s->qdev); +EbusState *s = container_of(pci_dev, EbusState, pci_dev); DO_UPCAST() is the qdev macro for this. Fixed. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH v3 29/39] sun4u: convert to memory API

2011-08-05 Thread Anthony Liguori
On 08/04/2011 08:06 AM, Avi Kivity wrote: fixes memory leak on repeated BAR map/unmap Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/sun4u.c | 55 +-- 1 files changed, 25 insertions(+), 30 deletions(-) diff --git a/hw/sun

[Qemu-devel] [PATCH v3 29/39] sun4u: convert to memory API

2011-08-04 Thread Avi Kivity
fixes memory leak on repeated BAR map/unmap Reviewed-by: Richard Henderson Signed-off-by: Avi Kivity --- hw/sun4u.c | 55 +-- 1 files changed, 25 insertions(+), 30 deletions(-) diff --git a/hw/sun4u.c b/hw/sun4u.c index d7dcaf0..74a06a8 100