Re: [Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-23 Thread Richard Henderson
On 09/23/2015 01:37 PM, Peter Maydell wrote: On 23 September 2015 at 13:00, Richard Henderson wrote: I've wondered about over-allocating on the mmap path, so that we can choose the hugepage aligned subregion. But as far as I can tell, my kernel doesn't allocate hugepages at all, no matter what

Re: [Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-23 Thread Peter Maydell
On 23 September 2015 at 13:00, Richard Henderson wrote: > On 09/23/2015 12:39 PM, Peter Maydell wrote: >> I think we're now doing the MADV_HUGEPAGE over "buffer size >> minus a page" rather than "buffer size". Does that mean >> we've gone from doing the madvise on a whole number of >> hugepages to

Re: [Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-23 Thread Richard Henderson
On 09/23/2015 12:39 PM, Peter Maydell wrote: >> +# ifdef _WIN32 > > Why the space before ifdef here ? #ifdef USE_STATIC_CODE_GEN_BUFFER # ifdef _WIN32 # else # endif /* WIN32 */ #elif defined(_WIN32) #else #endif It's something that glibc requires for its coding style, and I find myself using it

Re: [Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-23 Thread Peter Maydell
On 22 September 2015 at 13:25, Richard Henderson wrote: > This will catch any overflow of the buffer. > > Add a native win32 alternative for alloc_code_gen_buffer; > remove the malloc alternative. > > Signed-off-by: Richard Henderson > --- > translate-all.c | 210 > +

[Qemu-devel] [PATCH v3 24/25] tcg: Allocate a guard page after code_gen_buffer

2015-09-22 Thread Richard Henderson
This will catch any overflow of the buffer. Add a native win32 alternative for alloc_code_gen_buffer; remove the malloc alternative. Signed-off-by: Richard Henderson --- translate-all.c | 210 1 file changed, 119 insertions(+), 91 deletio