Re: [Qemu-devel] [PATCH v3 22/22] pc: support for virtio-pmem

2018-09-21 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 21/09/2018 18:55, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> On 21/09/2018 18:00, Dr. David Alan Gilbert wrote: > >>> * David Hildenbrand (da...@redhat.com) wrote: > Compile virtio-pmem for x86 and pro

Re: [Qemu-devel] [PATCH v3 22/22] pc: support for virtio-pmem

2018-09-21 Thread David Hildenbrand
On 21/09/2018 18:55, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> On 21/09/2018 18:00, Dr. David Alan Gilbert wrote: >>> * David Hildenbrand (da...@redhat.com) wrote: Compile virtio-pmem for x86 and properly hotplug virtio-pmem devices (memory-device pa

Re: [Qemu-devel] [PATCH v3 22/22] pc: support for virtio-pmem

2018-09-21 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > On 21/09/2018 18:00, Dr. David Alan Gilbert wrote: > > * David Hildenbrand (da...@redhat.com) wrote: > >> Compile virtio-pmem for x86 and properly hotplug virtio-pmem devices > >> (memory-device part) from our pc machine hotplug handler. > >> > >> Sig

Re: [Qemu-devel] [PATCH v3 22/22] pc: support for virtio-pmem

2018-09-21 Thread David Hildenbrand
On 21/09/2018 18:00, Dr. David Alan Gilbert wrote: > * David Hildenbrand (da...@redhat.com) wrote: >> Compile virtio-pmem for x86 and properly hotplug virtio-pmem devices >> (memory-device part) from our pc machine hotplug handler. >> >> Signed-off-by: David Hildenbrand > > I see a few other plac

Re: [Qemu-devel] [PATCH v3 22/22] pc: support for virtio-pmem

2018-09-21 Thread Dr. David Alan Gilbert
* David Hildenbrand (da...@redhat.com) wrote: > Compile virtio-pmem for x86 and properly hotplug virtio-pmem devices > (memory-device part) from our pc machine hotplug handler. > > Signed-off-by: David Hildenbrand I see a few other places in the pc subdir that have checks for TYPE_NVDIMM; can yo

[Qemu-devel] [PATCH v3 22/22] pc: support for virtio-pmem

2018-09-20 Thread David Hildenbrand
Compile virtio-pmem for x86 and properly hotplug virtio-pmem devices (memory-device part) from our pc machine hotplug handler. Signed-off-by: David Hildenbrand --- default-configs/i386-softmmu.mak | 1 + hw/i386/pc.c | 10 +- 2 files changed, 10 insertions(+), 1 dele