Re: [Qemu-devel] [PATCH v3 21/21] scsi: split command_complete callback in two

2011-05-20 Thread Paolo Bonzini
On 05/20/2011 06:11 PM, Christoph Hellwig wrote: +static void esp_command_complete(SCSIRequest *req, uint32_t arg) Shouldn't the "arg" argument to the new ->command_complete be renamed to something like "sense" or "status"? +static void esp_transfer_data(SCSIRequest *req, uint32_t arg) +{ +

Re: [Qemu-devel] [PATCH v3 21/21] scsi: split command_complete callback in two

2011-05-20 Thread Christoph Hellwig
> +static void esp_command_complete(SCSIRequest *req, uint32_t arg) Shouldn't the "arg" argument to the new ->command_complete be renamed to something like "sense" or "status"? > +static void esp_transfer_data(SCSIRequest *req, uint32_t arg) > +{ > +ESPState *s = DO_UPCAST(ESPState, busdev.qd

[Qemu-devel] [PATCH v3 21/21] scsi: split command_complete callback in two

2011-05-17 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini --- hw/esp.c | 60 +--- hw/lsi53c895a.c | 48 +++--- hw/scsi-bus.c|4 +- hw/scsi.h|9 + hw/spapr_vscsi.c | 101 ++ hw/usb-msd.c