Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-12 Thread Philippe Mathieu-Daudé
On 8/10/19 9:34 PM, Markus Armbruster wrote: > > My failure: > > $ make -C bld docker-test-build > make: Entering directory '/work/armbru/qemu/bld' > BUILD centos7 > make[1]: Entering directory '/work/armbru/qemu/bld' > GEN /work/armbru/qemu/bld/docker-src.2019-08-10-07.29.32.8915/qemu.

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-10 Thread Markus Armbruster
Alex Bennée writes: > Markus Armbruster writes: > >> Philippe Mathieu-Daudé writes: >> >>> On 8/9/19 8:46 AM, Markus Armbruster wrote: In my "build everything" tree, changing qemu/main-loop.h triggers a recompile of some 5600 out of 6600 objects (not counting tests and objects th

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Alex Bennée
Markus Armbruster writes: > Philippe Mathieu-Daudé writes: > >> On 8/9/19 8:46 AM, Markus Armbruster wrote: >>> In my "build everything" tree, changing qemu/main-loop.h triggers a >>> recompile of some 5600 out of 6600 objects (not counting tests and >>> objects that don't depend on qemu/osdep

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 1:55 PM, Markus Armbruster wrote: > Philippe Mathieu-Daudé writes: >> On 8/9/19 8:46 AM, Markus Armbruster wrote: >>> In my "build everything" tree, changing qemu/main-loop.h triggers a >>> recompile of some 5600 out of 6600 objects (not counting tests and >>> objects that don't depend o

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Markus Armbruster
Philippe Mathieu-Daudé writes: > On 8/9/19 8:46 AM, Markus Armbruster wrote: >> In my "build everything" tree, changing qemu/main-loop.h triggers a >> recompile of some 5600 out of 6600 objects (not counting tests and >> objects that don't depend on qemu/osdep.h). It includes block/aio.h, >> whi

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 12:29 PM, Philippe Mathieu-Daudé wrote: > On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote: > [...] >> netmap failing again :S >> >> $ make docker-image-debian-amd64 V=1 DEBUG=1 >> [...] >> CC net/netmap.o >> net/netmap.c: In function 'netmap_update_fd_handler': >> net/netmap.c:109

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote: [...] > netmap failing again :S > > $ make docker-image-debian-amd64 V=1 DEBUG=1 > [...] > CC net/netmap.o > net/netmap.c: In function 'netmap_update_fd_handler': > net/netmap.c:109:5: error: implicit declaration of function > 'qemu_set_fd_h

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 11:42 AM, Philippe Mathieu-Daudé wrote: [...] > netmap failing again :S > > $ make docker-image-debian-amd64 V=1 DEBUG=1 To clarify an incomplete paste, this command doesn't build QEMU. It build the docker image, start an container instance, and keep an interactive shell opened, so you

Re: [Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Philippe Mathieu-Daudé
On 8/9/19 8:46 AM, Markus Armbruster wrote: > In my "build everything" tree, changing qemu/main-loop.h triggers a > recompile of some 5600 out of 6600 objects (not counting tests and > objects that don't depend on qemu/osdep.h). It includes block/aio.h, > which in turn includes qemu/event_notifier

[Qemu-devel] [PATCH v3 20/29] Include qemu/main-loop.h less

2019-08-09 Thread Markus Armbruster
In my "build everything" tree, changing qemu/main-loop.h triggers a recompile of some 5600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). It includes block/aio.h, which in turn includes qemu/event_notifier.h, qemu/notify.h, qemu/processor.h, qemu/qsp.h, qem