Re: [Qemu-devel] [PATCH v3 20/20] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-03-28 Thread Richard Henderson
On 03/28/2013 09:44 AM, Peter Maydell wrote: >> +/* Prior to that the assembler uses mov r0, r0. Unlike the nop >> + above, this is guaranteed to consume execution resources. */ > > Guaranteed by who? Catching this case in the decoder and treating it > exactly like NOP is a per

Re: [Qemu-devel] [PATCH v3 20/20] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-03-28 Thread Peter Maydell
On 28 March 2013 15:33, Richard Henderson wrote: > +static inline void tcg_out_nop(TCGContext *s) > +{ > +if (use_armv7_instructions) { > +/* Architected nop introduced in v6k. */ > +/* ??? This is an MSR (imm) 0,0,0 insn. Anyone know if this > + also Just So Happen

[Qemu-devel] [PATCH v3 20/20] tcg-arm: Convert to CONFIG_QEMU_LDST_OPTIMIZATION

2013-03-28 Thread Richard Henderson
Move the slow path out of line, as the TODO's mention. This allows the fast path to be unconditional, which can speed up the fast path as well, depending on the core. Signed-off-by: Richard Henderson --- configure | 2 +- include/exec/exec-all.h | 17 +++ tcg/arm/tcg-target.c