Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 11:29:03 -0400 Corey Bryant wrote: > >> I'm not clear on what the problem is with returning the same error class > >> for two different errors. Could you explain? I don't have a problem > >> changing it if it's an issue. > > > > Because an mngt app/user won't know if what ha

Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Corey Bryant
On 06/15/2012 11:14 AM, Luiz Capitulino wrote: On Fri, 15 Jun 2012 11:04:16 -0400 Corey Bryant wrote: On 06/15/2012 10:32 AM, Luiz Capitulino wrote: On Thu, 14 Jun 2012 11:55:02 -0400 Corey Bryant wrote: This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd c

Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Fri, 15 Jun 2012 11:04:16 -0400 Corey Bryant wrote: > > > On 06/15/2012 10:32 AM, Luiz Capitulino wrote: > > On Thu, 14 Jun 2012 11:55:02 -0400 > > Corey Bryant wrote: > > > >> This patch adds the pass-fd QMP command using the QAPI framework. > >> Like the getfd command, it is used to pass

Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Corey Bryant
On 06/15/2012 10:32 AM, Luiz Capitulino wrote: On Thu, 14 Jun 2012 11:55:02 -0400 Corey Bryant wrote: This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the pass-fd command also returns the

Re: [Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-15 Thread Luiz Capitulino
On Thu, 14 Jun 2012 11:55:02 -0400 Corey Bryant wrote: > This patch adds the pass-fd QMP command using the QAPI framework. > Like the getfd command, it is used to pass a file descriptor via > SCM_RIGHTS. However, the pass-fd command also returns the received > file descriptor, which is a differe

[Qemu-devel] [PATCH v3 2/5] qapi: Add pass-fd QMP command

2012-06-14 Thread Corey Bryant
This patch adds the pass-fd QMP command using the QAPI framework. Like the getfd command, it is used to pass a file descriptor via SCM_RIGHTS. However, the pass-fd command also returns the received file descriptor, which is a difference in behavior from the getfd command, which returns nothing. T