Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-06-21 Thread Anthony Liguori
Sage Weil writes: > Hi Anthony, Stefan, Paolo, > > [Resurrecting an old thread, here!] > > On Wed, 10 Apr 2013 Anthony Liguori wrote: > > Has any progress been made toward a generic dynamic linking solution for > block drivers? It is a conceptually simple change, but non-trivial for > anyone u

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-06-21 Thread Alex Bligh
--On 21 June 2013 11:42:34 -0700 Sage Weil wrote: Has any progress been made toward a generic dynamic linking solution for block drivers? It is a conceptually simple change, but non-trivial for anyone unfamiliar with the build system. In the mean time, the inability to dynamically link libr

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-06-21 Thread Sage Weil
Hi Anthony, Stefan, Paolo, [Resurrecting an old thread, here!] On Wed, 10 Apr 2013 Anthony Liguori wrote: > Stefan Hajnoczi writes: > > NACK > > > > I think we're solving the problem at the wrong level. Writing our own > > dynamic linker and adding boilerplate to juggle function pointers > > ev

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-11 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 11:19:03PM +0200, Paolo Bonzini wrote: > Il 10/04/2013 17:08, Anthony Liguori ha scritto: > > /* This should not be used directly. Use block_init etc. instead. */ > > #ifdef CONFIG_MODULE > > #define module_init(function, type)\ > > const gchar *g_module_check_

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-11 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 10:08:20AM -0500, Anthony Liguori wrote: > Stefan Hajnoczi writes: > > > On Wed, Apr 10, 2013 at 2:05 AM, Josh Durgin > > wrote: > > NACK > > > > I think we're solving the problem at the wrong level. Writing our own > > dynamic linker and adding boilerplate to juggle fu

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-10 Thread Paolo Bonzini
Il 10/04/2013 17:08, Anthony Liguori ha scritto: > /* This should not be used directly. Use block_init etc. instead. */ > #ifdef CONFIG_MODULE > #define module_init(function, type) \ > const gchar *g_module_check_init(GModule *module) \ > {

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-10 Thread Anthony Liguori
Stefan Hajnoczi writes: > On Wed, Apr 10, 2013 at 2:05 AM, Josh Durgin wrote: > NACK > > I think we're solving the problem at the wrong level. Writing our own > dynamic linker and adding boilerplate to juggle function pointers > every time we use a library dependency is ugly. > > There are two

Re: [Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-10 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 2:05 AM, Josh Durgin wrote: > This allows the rbd block driver to detect symbols in the installed > version of librbd, and enable or disable features appropriately. This > obviates the #ifdefs regarding librbd versions. > > Loading librbd dynamically also makes the rbd blo

[Qemu-devel] [PATCH v3 2/2] rbd: link and load librbd dynamically

2013-04-09 Thread Josh Durgin
This allows the rbd block driver to detect symbols in the installed version of librbd, and enable or disable features appropriately. This obviates the #ifdefs regarding librbd versions. Loading librbd dynamically also makes the rbd block driver easier to install and package, since it removes the