Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
On 2013年11月14日 09:31, Wenchao Xia wrote: --- a/qapi-schema.json +++ b/qapi-schema.json @@ -948,8 +948,8 @@ # @tray_open: #optional True if the device has a tray and it is open # (only present if removable is true) # -# @dirty: #optional dirty bitmap information (only present i

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
On 2013年11月14日 10:13, Wenchao Xia wrote: 于 2013/11/13 22:40, Fam Zheng 写道: On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Wenchao Xia
于 2013/11/13 22:40, Fam Zheng 写道: On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. Signed-off-by: Fam Zhe

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Eric Blake
On 11/13/2013 06:31 PM, Wenchao Xia wrote: > >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -948,8 +948,8 @@ >> # @tray_open: #optional True if the device has a tray and it is open >> # (only present if removable is true) >> # >> -# @dirty: #optional dirty bitmap infor

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Wenchao Xia
--- a/qapi-schema.json +++ b/qapi-schema.json @@ -948,8 +948,8 @@ # @tray_open: #optional True if the device has a tray and it is open # (only present if removable is true) # -# @dirty: #optional dirty bitmap information (only present if the dirty -# bitmap is enabled)

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Eric Blake
On 11/13/2013 03:29 AM, Fam Zheng wrote: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. > > Signed-off-by: Fam Zheng > --- > block.c | 20 > block/qapi.c | 5 +

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Eric Blake
On 11/13/2013 07:19 AM, Kevin Wolf wrote: >> # >> -# @dirty: #optional dirty bitmap information (only present if the dirty >> -# bitmap is enabled) >> +# @dirty-bitmaps: #optional dirty bitmaps information (only present if the >> +# driver has one or more dirty bitmaps) >>

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Paolo Bonzini
Il 13/11/2013 15:19, Kevin Wolf ha scritto: > I believe this is of limited use; if you ever have more than one dirty > bitmap, we're lacking information to associate it with the job it > belongs to. One option would be to extend BlockDirtyInfo to indicate > this, but another might be to actually ex

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
On Wed, Nov 13, 2013 at 10:19 PM, Kevin Wolf wrote: > Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: >> We have multiple dirty bitmaps in BDS now, switch QAPI to allow query >> it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. >> >> Signed-off-by: Fam Zheng > >> diff --git a/qap

Re: [Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Kevin Wolf
Am 13.11.2013 um 11:29 hat Fam Zheng geschrieben: > We have multiple dirty bitmaps in BDS now, switch QAPI to allow query > it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. > > Signed-off-by: Fam Zheng > diff --git a/qapi-schema.json b/qapi-schema.json > index 81a375b..931d710 10

[Qemu-devel] [PATCH v3 2/2] qapi: Change BlockDirtyInfo to list

2013-11-13 Thread Fam Zheng
We have multiple dirty bitmaps in BDS now, switch QAPI to allow query it (BlockInfo.dirty_bitmaps), and also drop old BlockInfo.dirty. Signed-off-by: Fam Zheng --- block.c | 20 block/qapi.c | 5 + include/block/block.h | 1 + qapi-schema.json