Re: [Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

2019-03-08 Thread Philippe Mathieu-Daudé
On Fri, Mar 8, 2019 at 7:16 PM Auger Eric wrote: > Hi Philippe, > On 3/8/19 7:02 PM, Philippe Mathieu-Daudé wrote: > > hi Eric, > > > > On 3/8/19 4:25 PM, Eric Auger wrote: > >> As NVDIMM support is looming for ARM and SPAPR, let's > >> move the acpi_nvdimm_state to the generic machine struct > >>

Re: [Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

2019-03-08 Thread Auger Eric
Hi Philippe, On 3/8/19 7:02 PM, Philippe Mathieu-Daudé wrote: > hi Eric, > > On 3/8/19 4:25 PM, Eric Auger wrote: >> As NVDIMM support is looming for ARM and SPAPR, let's >> move the acpi_nvdimm_state to the generic machine struct >> instead of duplicating the same code in several machines. >> It

Re: [Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

2019-03-08 Thread Philippe Mathieu-Daudé
hi Eric, On 3/8/19 4:25 PM, Eric Auger wrote: > As NVDIMM support is looming for ARM and SPAPR, let's > move the acpi_nvdimm_state to the generic machine struct > instead of duplicating the same code in several machines. > It is also renamed into nvdimms_state and becomes a pointer. > > nvdimm an

Re: [Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

2019-03-08 Thread Eduardo Habkost
On Fri, Mar 08, 2019 at 02:42:14PM -0300, Eduardo Habkost wrote: > On Fri, Mar 08, 2019 at 04:25:11PM +0100, Eric Auger wrote: > [...] > > @@ -791,6 +833,28 @@ static void machine_initfn(Object *obj) > > ms->mem_merge = true; > > ms->enable_graphics = true; > > > > +if (mc->nvdimm_s

Re: [Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

2019-03-08 Thread Eduardo Habkost
On Fri, Mar 08, 2019 at 04:25:11PM +0100, Eric Auger wrote: [...] > @@ -791,6 +833,28 @@ static void machine_initfn(Object *obj) > ms->mem_merge = true; > ms->enable_graphics = true; > > +if (mc->nvdimm_supported) { > +ObjectClass *oc = OBJECT_CLASS(mc); > + > +ms->n

[Qemu-devel] [PATCH v3 2/2] machine: Move nvdimms state into struct MachineState

2019-03-08 Thread Eric Auger
As NVDIMM support is looming for ARM and SPAPR, let's move the acpi_nvdimm_state to the generic machine struct instead of duplicating the same code in several machines. It is also renamed into nvdimms_state and becomes a pointer. nvdimm and nvdimm-persistence become generic machine options. They b