Re: [Qemu-devel] [PATCH v3 2/1] libqtest: add more exit status checks

2018-05-24 Thread Michael S. Tsirkin
On Thu, May 24, 2018 at 07:58:06PM +0200, Thomas Huth wrote: > On 24.05.2018 19:33, Michael S. Tsirkin wrote: > > On Thu, May 24, 2018 at 07:26:16PM +0200, Thomas Huth wrote: > >> On 24.05.2018 18:11, Michael S. Tsirkin wrote: > >>> Add more checks on how did QEMU exit. > >>> > >>> Legal ways to ex

Re: [Qemu-devel] [PATCH v3 2/1] libqtest: add more exit status checks

2018-05-24 Thread Thomas Huth
On 24.05.2018 19:33, Michael S. Tsirkin wrote: > On Thu, May 24, 2018 at 07:26:16PM +0200, Thomas Huth wrote: >> On 24.05.2018 18:11, Michael S. Tsirkin wrote: >>> Add more checks on how did QEMU exit. >>> >>> Legal ways to exit right now: >>> - exit(0) or return from main >>> - kill(SIGTERM) - sen

Re: [Qemu-devel] [PATCH v3 2/1] libqtest: add more exit status checks

2018-05-24 Thread Michael S. Tsirkin
On Thu, May 24, 2018 at 07:26:16PM +0200, Thomas Huth wrote: > On 24.05.2018 18:11, Michael S. Tsirkin wrote: > > Add more checks on how did QEMU exit. > > > > Legal ways to exit right now: > > - exit(0) or return from main > > - kill(SIGTERM) - sent by testing infrastructure > > > > Anything els

Re: [Qemu-devel] [PATCH v3 2/1] libqtest: add more exit status checks

2018-05-24 Thread Thomas Huth
On 24.05.2018 18:11, Michael S. Tsirkin wrote: > Add more checks on how did QEMU exit. > > Legal ways to exit right now: > - exit(0) or return from main > - kill(SIGTERM) - sent by testing infrastructure > > Anything else is illegal. [...] > -if (pid == s->qemu_pid && WIFSIGNALED(wstatus)

[Qemu-devel] [PATCH v3 2/1] libqtest: add more exit status checks

2018-05-24 Thread Michael S. Tsirkin
Add more checks on how did QEMU exit. Legal ways to exit right now: - exit(0) or return from main - kill(SIGTERM) - sent by testing infrastructure Anything else is illegal. Include explicit asserts on bad behaviour encountered to make debugging easier. Signed-off-by: Michael S. Tsirkin --- Ch