Re: [Qemu-devel] [PATCH v3 18/21] scsi-disk: add data direction checking

2011-05-20 Thread Christoph Hellwig
> -typedef struct SCSIDiskReq { > + typedef struct SCSIDiskReq { Random whiyespace change. Otherwise looks good, Reviewed-by: Christoph Hellwig

[Qemu-devel] [PATCH v3 18/21] scsi-disk: add data direction checking

2011-05-17 Thread Paolo Bonzini
From: Hannes Reinecke scsi_req_parse() already provides for a data direction setting, so we should be using it to check for correct direction. And we should return the sense code 'INVALID FIELD IN CDB' in these cases. Signed-off-by: Hannes Reinecke Signed-off-by: Paolo Bonzini --- hw/scsi-dis