Re: [Qemu-devel] [PATCH v3 16/21] target-mips: add new Floating Point instructions

2014-10-03 Thread Leon Alrae
Hi Yongbok, On 02/10/2014 17:10, Yongbok Kim wrote: > Hi, > > Overall looking good but has issues with not freeing tcg_temps and some > style problem which > failed with the checkpatch.pl script. I remember that checkpatch.pl just hung on this patch, probably due to macros. Regards, Leon

Re: [Qemu-devel] [PATCH v3 16/21] target-mips: add new Floating Point instructions

2014-10-02 Thread Yongbok Kim
Hi, Overall looking good but has issues with not freeing tcg_temps and some style problem which failed with the checkpatch.pl script. Otherwise Reviewed-by: Yongbok Kim Regards, Yongbok On 27/06/2014 16:22, Leon Alrae wrote: In terms of encoding MIPS32R6 MIN.fmt, MAX.fmt, MINA.fmt, MAXA.fm

[Qemu-devel] [PATCH v3 16/21] target-mips: add new Floating Point instructions

2014-06-27 Thread Leon Alrae
In terms of encoding MIPS32R6 MIN.fmt, MAX.fmt, MINA.fmt, MAXA.fmt replaced MIPS-3D RECIP1, RECIP2, RSQRT1, RSQRT2 instructions. In R6 all Floating Point instructions are supposed to be IEEE-2008 compliant i.e. FIR.HAS2008 always 1. However, QEMU softfloat for MIPS has not been updated yet. Signe