Re: [Qemu-devel] [PATCH v3 16/20] tcg-arm: Fix local stack frame

2013-03-29 Thread Aurelien Jarno
On Thu, Mar 28, 2013 at 08:32:57AM -0700, Richard Henderson wrote: > We were not allocating TCG_STATIC_CALL_ARGS_SIZE, so this meant that > any helper with more than 4 arguments would clobber the saved regs. > Realizing that we're supposed to have this memory pre-allocated means > we can clean up t

[Qemu-devel] [PATCH v3 16/20] tcg-arm: Fix local stack frame

2013-03-28 Thread Richard Henderson
We were not allocating TCG_STATIC_CALL_ARGS_SIZE, so this meant that any helper with more than 4 arguments would clobber the saved regs. Realizing that we're supposed to have this memory pre-allocated means we can clean up the tcg_out_arg functions, which were trying to do more stack allocation. A