Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header

2015-07-18 Thread Paolo Bonzini
On 18/07/2015 17:37, Peter Crosthwaite wrote: > > > Would it be possible, or make sense, to do > > > > > > #define target_long arm_target_long > > > #define target_ulong arm_target_ulong > > > > > > instead? This makes prototypes nicer when printed in the debugger with > > > ptype. Where could

Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header

2015-07-18 Thread Peter Crosthwaite
On Sat, Jul 18, 2015 at 5:37 AM, Paolo Bonzini wrote: > > > On 18/07/2015 14:16, Paolo Bonzini wrote: >>> > +/* target_ulong is the type of a virtual address */ >>> > +#if TARGET_LONG_SIZE == 4 >>> > +#define target_long int32_t >>> > +#define target_ulong uint32_t >>> > +#define TARGET_FMT_lx "%0

Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header

2015-07-18 Thread Paolo Bonzini
On 18/07/2015 14:16, Paolo Bonzini wrote: >> > +/* target_ulong is the type of a virtual address */ >> > +#if TARGET_LONG_SIZE == 4 >> > +#define target_long int32_t >> > +#define target_ulong uint32_t >> > +#define TARGET_FMT_lx "%08x" >> > +#define TARGET_FMT_ld "%d" >> > +#define TARGET_FMT_lu

Re: [Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header

2015-07-18 Thread Paolo Bonzini
On 18/07/2015 11:40, Peter Crosthwaite wrote: > +/* target_ulong is the type of a virtual address */ > +#if TARGET_LONG_SIZE == 4 > +#define target_long int32_t > +#define target_ulong uint32_t > +#define TARGET_FMT_lx "%08x" > +#define TARGET_FMT_ld "%d" > +#define TARGET_FMT_lu "%u" > +#elif TA

[Qemu-devel] [PATCH v3 15/35] include/exec: Split target_long def to new header

2015-07-18 Thread Peter Crosthwaite
This is currently provided by cpu-defs and is a target specific definition. However, to prepare for multi-arch only the bare minimum content from cpu-defs.h should be exported to core code. And this is all we need. So split it to a new header that the target_multi cpu.h can include to save on havin