Re: [Qemu-devel] [PATCH v3 11/24] cpu/a15mpcore: Embed GICState

2013-08-22 Thread Peter Maydell
On 22 August 2013 11:56, Andreas Färber wrote: > Am 21.08.2013 23:05, schrieb Peter Maydell: > Not sure if a union of only one member is permitted? We're not actually > accessing the GICState, only void* and DEVICE()/SYS_BUS_DEVICE(), so it > just needs to block the memory, hopefully without needi

Re: [Qemu-devel] [PATCH v3 11/24] cpu/a15mpcore: Embed GICState

2013-08-22 Thread Andreas Färber
Am 21.08.2013 23:05, schrieb Peter Maydell: > On 20 August 2013 16:21, Andreas Färber wrote: >> From: Andreas Färber >> >> This covers both emulated and KVM GIC. > >> @@ -35,40 +36,48 @@ typedef struct A15MPPrivState { >> uint32_t num_cpu; >> uint32_t num_irq; >> MemoryRegion cont

Re: [Qemu-devel] [PATCH v3 11/24] cpu/a15mpcore: Embed GICState

2013-08-21 Thread Peter Maydell
On 20 August 2013 16:21, Andreas Färber wrote: > From: Andreas Färber > > This covers both emulated and KVM GIC. > @@ -35,40 +36,48 @@ typedef struct A15MPPrivState { > uint32_t num_cpu; > uint32_t num_irq; > MemoryRegion container; > -DeviceState *gic; > + > +GICState gic

[Qemu-devel] [PATCH v3 11/24] cpu/a15mpcore: Embed GICState

2013-08-20 Thread Andreas Färber
From: Andreas Färber This covers both emulated and KVM GIC. Prepares for QOM realize. Signed-off-by: Andreas Färber --- hw/cpu/a15mpcore.c | 35 ++- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/hw/cpu/a15mpcore.c b/hw/cpu/a15mpcore.c index c2