Re: [Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation

2014-06-26 Thread Paolo Bonzini
Il 26/06/2014 16:43, Peter Maydell ha scritto: I wasn't expecting you to bother with the BE32 system emulation support :-) Did you have a test case for this? No, I didn't as shown by the generally hideous quality of this patch. They asked for it on the mailing list and it was fairly easy to do

Re: [Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation

2014-06-26 Thread Peter Maydell
On 21 June 2014 13:58, Paolo Bonzini wrote: > System emulation only has a little-endian target; BE32 mode > is implemented by adjusting the low bits of the address > for every byte and halfword load and store. 64-bit accesses > flip the low and high words. > > Signed-off-by: Paolo Bonzini > ---

Re: [Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation

2014-06-21 Thread Richard Henderson
On 06/21/2014 05:58 AM, Paolo Bonzini wrote: > @@ -855,32 +878,68 @@ static inline void gen_aa32_ld64(DisasContext *s, > TCGv_i64 val, TCGv_i32 addr, i > { > TCGMemOp opc = MO_Q | s->mo_endianness; > tcg_gen_qemu_ld_i64(val, addr, index, opc); > +#ifndef CONFIG_USER_ONLY > +/* Not n

[Qemu-devel] [PATCH v3 11/11] target-arm: implement BE32 mode in system emulation

2014-06-21 Thread Paolo Bonzini
System emulation only has a little-endian target; BE32 mode is implemented by adjusting the low bits of the address for every byte and halfword load and store. 64-bit accesses flip the low and high words. Signed-off-by: Paolo Bonzini --- target-arm/cpu.h | 5 +-- target-arm/translate.c