Re: [Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Nikunj A Dadhania
"Michael S. Tsirkin" writes: > On Wed, Mar 11, 2015 at 04:24:55PM +0530, Nikunj A Dadhania wrote: >> >> Hi Michael, >> >> "Michael S. Tsirkin" writes: >> > Drop duplicated code. >> > >> > Signed-off-by: Michael S. Tsirkin >> >> This patch is breaking SLOF. Reason below: > > Can you please tr

Re: [Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Michael S. Tsirkin
On Wed, Mar 11, 2015 at 04:24:55PM +0530, Nikunj A Dadhania wrote: > > Hi Michael, > > "Michael S. Tsirkin" writes: > > Drop duplicated code. > > > > Signed-off-by: Michael S. Tsirkin > > This patch is breaking SLOF. Reason below: Can you please try out this patch: mid.gmane.org/2015031110185

Re: [Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-03-11 Thread Nikunj A Dadhania
Hi Michael, "Michael S. Tsirkin" writes: > Drop duplicated code. > > Signed-off-by: Michael S. Tsirkin This patch is breaking SLOF. Reason below: > --- > include/hw/virtio/virtio-scsi.h | 120 > +++- > hw/scsi/virtio-scsi.c | 1 + > 2 files ch

Re: [Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-02-17 Thread Paolo Bonzini
On 16/02/2015 22:36, Michael S. Tsirkin wrote: > Drop duplicated code. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/virtio/virtio-scsi.h | 120 > +++- > hw/scsi/virtio-scsi.c | 1 + > 2 files changed, 10 insertions(+), 111 deletions(

[Qemu-devel] [PATCH v3 10/17] virtio-scsi: use standard-headers

2015-02-16 Thread Michael S. Tsirkin
Drop duplicated code. Signed-off-by: Michael S. Tsirkin --- include/hw/virtio/virtio-scsi.h | 120 +++- hw/scsi/virtio-scsi.c | 1 + 2 files changed, 10 insertions(+), 111 deletions(-) diff --git a/include/hw/virtio/virtio-scsi.h b/include/hw/virt