On 08.11.18 15:42, Eric Blake wrote:
> On 11/8/18 7:05 AM, David Hildenbrand wrote:
>
Thanks for the excessive answer! I think that should be enough to come
up with a RFC of a *rewrite* of the string input visitor :)
>>>
>>> You're welcome! I love great questions, they make me *think*.
On 08.11.18 15:36, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> I found some more ugliness, looking at the tests. I am not sure the test
>> is correct here.
>>
>> test_visitor_in_intList():
>>
>> v = visitor_input_test_init(data, "1,2,0,2-4,20,5-9,1-8");
>>
>> -> we expect { 0, 1, 2,
On 11/8/18 7:05 AM, David Hildenbrand wrote:
Thanks for the excessive answer! I think that should be enough to come
up with a RFC of a *rewrite* of the string input visitor :)
You're welcome! I love great questions, they make me *think*.
Besides, if something's worth doing, it's probably wor
David Hildenbrand writes:
> I found some more ugliness, looking at the tests. I am not sure the test
> is correct here.
>
> test_visitor_in_intList():
>
> v = visitor_input_test_init(data, "1,2,0,2-4,20,5-9,1-8");
>
> -> we expect { 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 20 }, implying that the
> visitor
On 08.11.18 10:13, Markus Armbruster wrote:
> David Hildenbrand writes:
>
Would it be valid to do something like this (skipping elements without a
proper visit_type_int)
visit_start_list();
visit_next_list(); more input, returns "there's more"
visit_next_list(); pa
David Hildenbrand writes:
>>> Would it be valid to do something like this (skipping elements without a
>>> proper visit_type_int)
>>>
>>> visit_start_list();
>>> visit_next_list(); more input, returns "there's more"
>>> visit_next_list(); parses "1-3,", buffers 2-3, skips over 1
>>> visit_type_
>> Would it be valid to do something like this (skipping elements without a
>> proper visit_type_int)
>>
>> visit_start_list();
>> visit_next_list(); more input, returns "there's more"
>> visit_next_list(); parses "1-3,", buffers 2-3, skips over 1
>> visit_type_int(); returns 2
>> ...
>
> Exce
David Hildenbrand writes:
> On 07.11.18 16:29, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 05.11.18 21:43, Markus Armbruster wrote:
David Hildenbrand writes:
> On 05.11.18 16:37, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 31.1
On 07.11.18 16:29, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 05.11.18 21:43, Markus Armbruster wrote:
>>> David Hildenbrand writes:
>>>
On 05.11.18 16:37, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 31.10.18 18:55, Markus Armbruster wrote:
>>
David Hildenbrand writes:
> On 05.11.18 21:43, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 05.11.18 16:37, Markus Armbruster wrote:
David Hildenbrand writes:
> On 31.10.18 18:55, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 31.1
On 05.11.18 17:48, Eric Blake wrote:
> On 11/5/18 9:53 AM, David Hildenbrand wrote:
>
>>> When I first looked at the ranges stuff in the string input visitor, I
>>> felt the urge to clean it up, then sat on my hands until it passed.
>>>
>>> The rest is reasonable once you understand how it works.
On 05.11.18 21:43, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 05.11.18 16:37, Markus Armbruster wrote:
>>> David Hildenbrand writes:
>>>
On 31.10.18 18:55, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 31.10.18 15:40, Markus Armbruster wrote:
>>
David Hildenbrand writes:
> On 05.11.18 16:37, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 31.10.18 18:55, Markus Armbruster wrote:
David Hildenbrand writes:
> On 31.10.18 15:40, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> The qem
On 11/5/18 9:53 AM, David Hildenbrand wrote:
When I first looked at the ranges stuff in the string input visitor, I
felt the urge to clean it up, then sat on my hands until it passed.
The rest is reasonable once you understand how it works. The learning
curve is less than pleasant, though.
On 05.11.18 16:37, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 31.10.18 18:55, Markus Armbruster wrote:
>>> David Hildenbrand writes:
>>>
On 31.10.18 15:40, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> The qemu api claims to be easier to use, and t
David Hildenbrand writes:
> On 31.10.18 18:55, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> On 31.10.18 15:40, Markus Armbruster wrote:
David Hildenbrand writes:
> The qemu api claims to be easier to use, and the resulting code seems to
> agree.
>> [...]
>
On 31.10.18 18:55, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> On 31.10.18 15:40, Markus Armbruster wrote:
>>> David Hildenbrand writes:
>>>
The qemu api claims to be easier to use, and the resulting code seems to
agree.
> [...]
@@ -60,9 +61,7 @@ static int parse_str
David Hildenbrand writes:
> On 31.10.18 15:40, Markus Armbruster wrote:
>> David Hildenbrand writes:
>>
>>> The qemu api claims to be easier to use, and the resulting code seems to
>>> agree.
[...]
>>> @@ -60,9 +61,7 @@ static int parse_str(StringInputVisitor *siv, const char
>>> *name, Error
On 31.10.18 15:40, Markus Armbruster wrote:
> David Hildenbrand writes:
>
>> The qemu api claims to be easier to use, and the resulting code seems to
>> agree.
>
> Ah, an opportunity to nitpick spelling! "The QEMU API", and "qapi: Use
> qemu_strtoi64() ..."
Whatever floats your boat ;) Will ch
David Hildenbrand writes:
> The qemu api claims to be easier to use, and the resulting code seems to
> agree.
Ah, an opportunity to nitpick spelling! "The QEMU API", and "qapi: Use
qemu_strtoi64() ..."
> Signed-off-by: David Hildenbrand
> ---
> qapi/string-input-visitor.c | 17 ++
On Tue, Oct 23, 2018 at 05:23:00PM +0200, David Hildenbrand wrote:
> The qemu api claims to be easier to use, and the resulting code seems to
> agree.
>
> Signed-off-by: David Hildenbrand
Reviewed-by: David Gibson
> ---
> qapi/string-input-visitor.c | 17 ++---
> 1 file changed,
The qemu api claims to be easier to use, and the resulting code seems to
agree.
Signed-off-by: David Hildenbrand
---
qapi/string-input-visitor.c | 17 ++---
1 file changed, 6 insertions(+), 11 deletions(-)
diff --git a/qapi/string-input-visitor.c b/qapi/string-input-visitor.c
index
22 matches
Mail list logo
