Re: [Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID

2014-12-03 Thread Don Koch
On Wed, 3 Dec 2014 18:28:36 +0800 Fam Zheng wrote: > This replaces two "time(NULL)" invocations with "g_random_int()". > According to VMDK spec, CID "is a random 32‐bit value updated the first > time the content of the virtual disk is modified after the virtual disk > is opened". Using "seconds s

Re: [Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID

2014-12-03 Thread Max Reitz
On 2014-12-03 at 11:28, Fam Zheng wrote: This replaces two "time(NULL)" invocations with "g_random_int()". According to VMDK spec, CID "is a random 32‐bit value updated the first time the content of the virtual disk is modified after the virtual disk is opened". Using "seconds since epoch" is jus

[Qemu-devel] [PATCH v3 1/6] vmdk: Use g_random_int to generate CID

2014-12-03 Thread Fam Zheng
This replaces two "time(NULL)" invocations with "g_random_int()". According to VMDK spec, CID "is a random 32‐bit value updated the first time the content of the virtual disk is modified after the virtual disk is opened". Using "seconds since epoch" is just a "lame way" to generate it, and not comp