Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Cornelia Huck
On Tue, 5 Feb 2019 09:41:15 -0500 Eric Farman wrote: > On 02/05/2019 07:03 AM, Cornelia Huck wrote: > > On Mon, 4 Feb 2019 14:25:34 -0500 > > Eric Farman wrote: > > > >> On 01/30/2019 08:22 AM, Cornelia Huck wrote: > >>> @@ -760,6 +764,10 @@ int cp_prefetch(struct channel_program *cp) > >>

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Cornelia Huck
On Tue, 5 Feb 2019 10:14:46 -0500 Farhan Ali wrote: > On 02/05/2019 09:48 AM, Eric Farman wrote: > >>> This patch-series is AFAICT a big improvement over what we have. I would > >>> like Farhan confirming that it makes these hick-ups when he used to hit > >>> BUSY with another ssch request disap

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Farhan Ali
On 02/05/2019 09:48 AM, Eric Farman wrote: On 02/05/2019 07:35 AM, Cornelia Huck wrote: On Tue, 5 Feb 2019 12:52:29 +0100 Halil Pasic wrote: On Mon, 4 Feb 2019 16:31:02 +0100 Cornelia Huck wrote: On Thu, 31 Jan 2019 13:34:55 +0100 Halil Pasic wrote: On Thu, 31 Jan 2019 12:52:20 +010

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Eric Farman
On 02/05/2019 07:03 AM, Cornelia Huck wrote: On Mon, 4 Feb 2019 14:25:34 -0500 Eric Farman wrote: On 01/30/2019 08:22 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Mak

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Eric Farman
On 02/05/2019 07:35 AM, Cornelia Huck wrote: On Tue, 5 Feb 2019 12:52:29 +0100 Halil Pasic wrote: On Mon, 4 Feb 2019 16:31:02 +0100 Cornelia Huck wrote: On Thu, 31 Jan 2019 13:34:55 +0100 Halil Pasic wrote: On Thu, 31 Jan 2019 12:52:20 +0100 Cornelia Huck wrote: On Wed, 30 Ja

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Cornelia Huck
On Tue, 5 Feb 2019 12:52:29 +0100 Halil Pasic wrote: > On Mon, 4 Feb 2019 16:31:02 +0100 > Cornelia Huck wrote: > > > On Thu, 31 Jan 2019 13:34:55 +0100 > > Halil Pasic wrote: > > > > > On Thu, 31 Jan 2019 12:52:20 +0100 > > > Cornelia Huck wrote: > > > > > > > On Wed, 30 Jan 2019 19:51

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Cornelia Huck
On Mon, 4 Feb 2019 14:25:34 -0500 Eric Farman wrote: > On 01/30/2019 08:22 AM, Cornelia Huck wrote: > > When we get a solicited interrupt, the start function may have > > been cleared by a csch, but we still have a channel program > > structure allocated. Make it safe to call the cp accessors in

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Halil Pasic
On Mon, 4 Feb 2019 16:31:02 +0100 Cornelia Huck wrote: > On Thu, 31 Jan 2019 13:34:55 +0100 > Halil Pasic wrote: > > > On Thu, 31 Jan 2019 12:52:20 +0100 > > Cornelia Huck wrote: > > > > > On Wed, 30 Jan 2019 19:51:27 +0100 > > > Halil Pasic wrote: > > > > > > > On Wed, 30 Jan 2019 14:22:

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-04 Thread Eric Farman
On 01/30/2019 08:22 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it safe to call the cp accessors in any case, so we can call them unconditionally. While at it, als

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-04 Thread Cornelia Huck
On Thu, 31 Jan 2019 13:34:55 +0100 Halil Pasic wrote: > On Thu, 31 Jan 2019 12:52:20 +0100 > Cornelia Huck wrote: > > > On Wed, 30 Jan 2019 19:51:27 +0100 > > Halil Pasic wrote: > > > > > On Wed, 30 Jan 2019 14:22:07 +0100 > > > Cornelia Huck wrote: > > > > > > > When we get a solicited

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-01-31 Thread Halil Pasic
On Thu, 31 Jan 2019 12:52:20 +0100 Cornelia Huck wrote: > On Wed, 30 Jan 2019 19:51:27 +0100 > Halil Pasic wrote: > > > On Wed, 30 Jan 2019 14:22:07 +0100 > > Cornelia Huck wrote: > > > > > When we get a solicited interrupt, the start function may have > > > been cleared by a csch, but we sti

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-01-31 Thread Cornelia Huck
On Wed, 30 Jan 2019 19:51:27 +0100 Halil Pasic wrote: > On Wed, 30 Jan 2019 14:22:07 +0100 > Cornelia Huck wrote: > > > When we get a solicited interrupt, the start function may have > > been cleared by a csch, but we still have a channel program > > structure allocated. Make it safe to call th

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-01-30 Thread Halil Pasic
On Wed, 30 Jan 2019 14:22:07 +0100 Cornelia Huck wrote: > When we get a solicited interrupt, the start function may have > been cleared by a csch, but we still have a channel program > structure allocated. Make it safe to call the cp accessors in > any case, so we can call them unconditionally.

[Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-01-30 Thread Cornelia Huck
When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated. Make it safe to call the cp accessors in any case, so we can call them unconditionally. While at it, also make sure that functions called from other parts