Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread John Snow
On 8/29/19 2:58 PM, Philippe Mathieu-Daudé wrote: > On 8/29/19 8:43 PM, John Snow wrote: >> On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote: >>> This restrict test 208 to the Linux platform, is this OK? >>> >>> The rest looks good. >> >> I forgot about that, so good catch. >> >> I don't know. W

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/29/19 8:43 PM, John Snow wrote: > On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote: >> This restrict test 208 to the Linux platform, is this OK? >> >> The rest looks good. > > I forgot about that, so good catch. > > I don't know. We seem to already restrict a LOT of tests to the Linux > plat

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread John Snow
On 8/29/19 2:27 PM, Philippe Mathieu-Daudé wrote: > This restrict test 208 to the Linux platform, is this OK? > > The rest looks good. I forgot about that, so good catch. I don't know. We seem to already restrict a LOT of tests to the Linux platform. Does this one actually work on other platf

Re: [Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-29 Thread Philippe Mathieu-Daudé
On 8/21/19 1:52 AM, John Snow wrote: > Like script_main, but doesn't require a single point of entry. > Replace all existing initialization sections with this drop-in replacement. > > This brings debug support to all existing script-style iotests. > > Note: supported_oses=['linux'] was omitted, a

[Qemu-devel] [PATCH v3 1/4] iotests: add script_initialize

2019-08-20 Thread John Snow
Like script_main, but doesn't require a single point of entry. Replace all existing initialization sections with this drop-in replacement. This brings debug support to all existing script-style iotests. Note: supported_oses=['linux'] was omitted, as it is a default argument. --- tests/qemu-iotes