Re: [Qemu-devel] [PATCH v3 1/4] hw/virtio: Factorize virtio-mmio headers

2019-07-25 Thread Paolo Bonzini
On 25/07/19 11:58, Michael S. Tsirkin wrote: > I'm repeating myself, but still: if you insist on virtio mmio, please > implement virtio 1 and use that with microvm. We can't keep carrying > legacy interface into every new machine type. I'd give Sergio the benefit of doubt, since so far he's addres

Re: [Qemu-devel] [PATCH v3 1/4] hw/virtio: Factorize virtio-mmio headers

2019-07-25 Thread Peter Maydell
On Thu, 25 Jul 2019 at 10:58, Michael S. Tsirkin wrote: > > On Thu, Jul 25, 2019 at 10:46:00AM +0100, Liam Merwick wrote: > > On 02/07/2019 13:11, Sergio Lopez wrote: > > > Put QOM and main struct definition in a separate header file, so it > > > can be accesed from other components. > > > > typo:

Re: [Qemu-devel] [PATCH v3 1/4] hw/virtio: Factorize virtio-mmio headers

2019-07-25 Thread Michael S. Tsirkin
On Thu, Jul 25, 2019 at 10:46:00AM +0100, Liam Merwick wrote: > On 02/07/2019 13:11, Sergio Lopez wrote: > > Put QOM and main struct definition in a separate header file, so it > > can be accesed from other components. > > typo: accesed -> accessed > > > > > This is needed for the microvm machin

Re: [Qemu-devel] [PATCH v3 1/4] hw/virtio: Factorize virtio-mmio headers

2019-07-25 Thread Liam Merwick
On 02/07/2019 13:11, Sergio Lopez wrote: Put QOM and main struct definition in a separate header file, so it can be accesed from other components. typo: accesed -> accessed This is needed for the microvm machine type implementation. Signed-off-by: Sergio Lopez One nit below, either way

[Qemu-devel] [PATCH v3 1/4] hw/virtio: Factorize virtio-mmio headers

2019-07-02 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accesed from other components. This is needed for the microvm machine type implementation. Signed-off-by: Sergio Lopez --- hw/virtio/virtio-mmio.c | 35 +--- hw/virtio/virtio-mmio.h | 60 +