Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Luiz Capitulino
On Wed, 11 Jun 2014 15:36:57 +0200 Cornelia Huck wrote: > On Wed, 11 Jun 2014 09:10:36 -0400 > Luiz Capitulino wrote: > > > On Tue, 10 Jun 2014 18:29:43 +0200 > > Paolo Bonzini wrote: > > > > > Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > > > > > The s390 restart interrupt is a per-vcpu

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Cornelia Huck
On Wed, 11 Jun 2014 09:10:36 -0400 Luiz Capitulino wrote: > On Tue, 10 Jun 2014 18:29:43 +0200 > Paolo Bonzini wrote: > > > Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > > > > The s390 restart interrupt is a per-vcpu interrupt, which we really > > > > don't want to inject on _all_ vcpus. O

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Luiz Capitulino
On Tue, 10 Jun 2014 18:29:43 +0200 Paolo Bonzini wrote: > Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > > > The s390 restart interrupt is a per-vcpu interrupt, which we really > > > don't want to inject on _all_ vcpus. OTOH, we want to inject that > > > interrupt on any vcpu - we don't care

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Luiz Capitulino
On Wed, 11 Jun 2014 01:40:14 +1000 Alexey Kardashevskiy wrote: > On 06/10/2014 11:39 PM, Luiz Capitulino wrote: > > On Wed, 4 Jun 2014 18:08:47 +1000 > > Alexey Kardashevskiy wrote: > > > >> This introduces an NMI (non maskable interrupt) callback per CPU class > >> which QMP's "nmi" command m

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 06/11/2014 12:47 PM, Paolo Bonzini wrote: Il 11/06/2014 10:42, Alexander Graf ha scritto: On 11.06.14 10:37, Paolo Bonzini wrote: Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 10:42, Alexander Graf ha scritto: On 11.06.14 10:37, Paolo Bonzini wrote: Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a way. You could argue that Alexey does need s

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 11:04, Alexey Kardashevskiy wrote: On 06/11/2014 10:28 AM, Alexander Graf wrote: Am 11.06.2014 um 02:23 schrieb Peter Maydell : On 10 June 2014 19:09, Alexander Graf wrote: I agree. I see two different paths forward: 1) Use the patches as they are - they seem pretty sound an

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Cornelia Huck
On Wed, 11 Jun 2014 10:38:14 +0200 Cornelia Huck wrote: > On Wed, 11 Jun 2014 16:50:35 +1000 > Alexey Kardashevskiy wrote: > > > On 06/11/2014 12:41 AM, Cornelia Huck wrote: > > > On Tue, 10 Jun 2014 09:39:51 -0400 > > > Luiz Capitulino wrote: > > > > > >> On Wed, 4 Jun 2014 18:08:47 +1000 >

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexey Kardashevskiy
On 06/11/2014 10:28 AM, Alexander Graf wrote: > > >> Am 11.06.2014 um 02:23 schrieb Peter Maydell : >> >>> On 10 June 2014 19:09, Alexander Graf wrote: >>> I agree. I see two different paths forward: >>> >>> 1) Use the patches as they are - they seem pretty sound and take the >>> existing x86/s

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 10:37, Paolo Bonzini wrote: Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a way. You could argue that Alexey does need something different thanks to his need to inject t

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Cornelia Huck
On Wed, 11 Jun 2014 16:50:35 +1000 Alexey Kardashevskiy wrote: > On 06/11/2014 12:41 AM, Cornelia Huck wrote: > > On Tue, 10 Jun 2014 09:39:51 -0400 > > Luiz Capitulino wrote: > > > >> On Wed, 4 Jun 2014 18:08:47 +1000 > >> Alexey Kardashevskiy wrote: > >> > >>> This introduces an NMI (non ma

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 10:29, Alexander Graf ha scritto: But right now inject-nmi was a CPU-specific interface and whoever needs something different will have to find a way. You could argue that Alexey does need something different thanks to his need to inject the NMI on all CPUs. What about an NMIMoni

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 10:27, Paolo Bonzini wrote: Il 11/06/2014 10:01, Alexander Graf ha scritto: Personally, I don't see anything wrong in these patches, apart from the typo that Cornelia pointed out. If you wanted to inject an NMI on non-sPAPR machines, such as -M mac99 or -M g3beige you would have t

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 10:01, Alexander Graf ha scritto: Personally, I don't see anything wrong in these patches, apart from the typo that Cornelia pointed out. If you wanted to inject an NMI on non-sPAPR machines, such as -M mac99 or -M g3beige you would have to trigger an interrupt with the MPIC, not

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Alexander Graf
On 11.06.14 06:59, Paolo Bonzini wrote: Il 11/06/2014 02:28, Alexander Graf ha scritto: Am 11.06.2014 um 02:23 schrieb Peter Maydell : On 10 June 2014 19:09, Alexander Graf wrote: I agree. I see two different paths forward: 1) Use the patches as they are - they seem pretty sound and ta

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-11 Thread Paolo Bonzini
Il 11/06/2014 08:50, Alexey Kardashevskiy ha scritto: And I changed x86 to inject NMI on the default CPU only (used to be on all CPUs), and I wonder again if it is actually ok and won't break things. For x86 it is better to send it to one CPU only. Paolo

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Alexey Kardashevskiy
On 06/11/2014 12:41 AM, Cornelia Huck wrote: > On Tue, 10 Jun 2014 09:39:51 -0400 > Luiz Capitulino wrote: > >> On Wed, 4 Jun 2014 18:08:47 +1000 >> Alexey Kardashevskiy wrote: >> >>> This introduces an NMI (non maskable interrupt) callback per CPU class >>> which QMP's "nmi" command may use to

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Paolo Bonzini
Il 11/06/2014 02:28, Alexander Graf ha scritto: Am 11.06.2014 um 02:23 schrieb Peter Maydell : On 10 June 2014 19:09, Alexander Graf wrote: I agree. I see two different paths forward: 1) Use the patches as they are - they seem pretty sound and take the existing x86/s390 only feature to sp

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Alexander Graf
> Am 11.06.2014 um 02:23 schrieb Peter Maydell : > >> On 10 June 2014 19:09, Alexander Graf wrote: >> I agree. I see two different paths forward: >> >> 1) Use the patches as they are - they seem pretty sound and take the >> existing x86/s390 only feature to spapr >> 2) Model an "NMI" button.

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Peter Maydell
On 10 June 2014 19:09, Alexander Graf wrote: > I agree. I see two different paths forward: > > 1) Use the patches as they are - they seem pretty sound and take the > existing x86/s390 only feature to spapr > 2) Model an "NMI" button. That button would get instantiated by the > machine model. T

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Alexander Graf
> Am 11.06.2014 um 02:12 schrieb Alexey Kardashevskiy : > >> On 06/11/2014 04:09 AM, Alexander Graf wrote: >>> On 06/10/2014 06:29 PM, Paolo Bonzini wrote: >>> Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > The s390 restart interrupt is a per-vcpu interrupt, which we really > don't w

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Alexey Kardashevskiy
On 06/11/2014 04:09 AM, Alexander Graf wrote: > On 06/10/2014 06:29 PM, Paolo Bonzini wrote: >> Il 10/06/2014 16:48, Luiz Capitulino ha scritto: >>> > The s390 restart interrupt is a per-vcpu interrupt, which we really >>> > don't want to inject on _all_ vcpus. OTOH, we want to inject that >>> > in

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Alexander Graf
On 06/10/2014 06:29 PM, Paolo Bonzini wrote: Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > The s390 restart interrupt is a per-vcpu interrupt, which we really > don't want to inject on _all_ vcpus. OTOH, we want to inject that > interrupt on any vcpu - we don't care which one it is. So I'd

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Paolo Bonzini
Il 10/06/2014 16:48, Luiz Capitulino ha scritto: > The s390 restart interrupt is a per-vcpu interrupt, which we really > don't want to inject on _all_ vcpus. OTOH, we want to inject that > interrupt on any vcpu - we don't care which one it is. So I'd really > like an "inject nmi on default cpu" o

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Alexey Kardashevskiy
On 06/10/2014 11:39 PM, Luiz Capitulino wrote: > On Wed, 4 Jun 2014 18:08:47 +1000 > Alexey Kardashevskiy wrote: > >> This introduces an NMI (non maskable interrupt) callback per CPU class >> which QMP's "nmi" command may use to issue NMI on a CPU. >> >> This adds support for it in qmp_inject_nm

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Eric Blake
On 06/10/2014 07:39 AM, Luiz Capitulino wrote: > On Wed, 4 Jun 2014 18:08:47 +1000 > Alexey Kardashevskiy wrote: > >> This introduces an NMI (non maskable interrupt) callback per CPU class >> which QMP's "nmi" command may use to issue NMI on a CPU. >> >> This adds support for it in qmp_inject_nm

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Luiz Capitulino
On Tue, 10 Jun 2014 16:41:07 +0200 Cornelia Huck wrote: > On Tue, 10 Jun 2014 09:39:51 -0400 > Luiz Capitulino wrote: > > > On Wed, 4 Jun 2014 18:08:47 +1000 > > Alexey Kardashevskiy wrote: > > > > > This introduces an NMI (non maskable interrupt) callback per CPU class > > > which QMP's "nm

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Cornelia Huck
On Tue, 10 Jun 2014 09:39:51 -0400 Luiz Capitulino wrote: > On Wed, 4 Jun 2014 18:08:47 +1000 > Alexey Kardashevskiy wrote: > > > This introduces an NMI (non maskable interrupt) callback per CPU class > > which QMP's "nmi" command may use to issue NMI on a CPU. > > > > This adds support for i

Re: [Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-10 Thread Luiz Capitulino
On Wed, 4 Jun 2014 18:08:47 +1000 Alexey Kardashevskiy wrote: > This introduces an NMI (non maskable interrupt) callback per CPU class > which QMP's "nmi" command may use to issue NMI on a CPU. > > This adds support for it in qmp_inject_nmi(). Since no architecture > supports it at the moment,

[Qemu-devel] [PATCH v3 1/4] cpus: Define NMI callback

2014-06-04 Thread Alexey Kardashevskiy
This introduces an NMI (non maskable interrupt) callback per CPU class which QMP's "nmi" command may use to issue NMI on a CPU. This adds support for it in qmp_inject_nmi(). Since no architecture supports it at the moment, there is no change in behaviour. This changes inject-nmi command descripti