Re: [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-12-22 Thread Fam Zheng
On Fri, 12/19 09:20, Markus Armbruster wrote: > Fam Zheng writes: > > > On Wed, 12/17 10:36, Markus Armbruster wrote: > >> Fam Zheng writes: > >> > >> > Similar to drive-backup, but this command uses a device id as target > >> > instead of creating/opening an image file. > >> > > >> > Also add

Re: [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-12-19 Thread Markus Armbruster
Fam Zheng writes: > On Wed, 12/17 10:36, Markus Armbruster wrote: >> Fam Zheng writes: >> >> > Similar to drive-backup, but this command uses a device id as target >> > instead of creating/opening an image file. >> > >> > Also add blocker on target bs, since the target is also a named device >>

Re: [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-12-17 Thread Fam Zheng
On Wed, 12/17 10:36, Markus Armbruster wrote: > Fam Zheng writes: > > > Similar to drive-backup, but this command uses a device id as target > > instead of creating/opening an image file. > > > > Also add blocker on target bs, since the target is also a named device > > now. > > > > Add check and

Re: [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-12-17 Thread Markus Armbruster
Fam Zheng writes: > Similar to drive-backup, but this command uses a device id as target > instead of creating/opening an image file. > > Also add blocker on target bs, since the target is also a named device > now. > > Add check and report error for bs == target which became possible but is > an

Re: [Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-11-19 Thread Stefan Hajnoczi
On Wed, Nov 05, 2014 at 10:57:09AM +0800, Fam Zheng wrote: > +void qmp_blockdev_backup(const char *device, const char *target, > + enum MirrorSyncMode sync, > + bool has_speed, int64_t speed, > + bool has_on_source_error, > +

[Qemu-devel] [PATCH v3 1/3] qmp: Add command 'blockdev-backup'

2014-11-04 Thread Fam Zheng
Similar to drive-backup, but this command uses a device id as target instead of creating/opening an image file. Also add blocker on target bs, since the target is also a named device now. Add check and report error for bs == target which became possible but is an illegal case with introduction of