Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-21 Thread Lukáš Doktor
Dne 20.7.2017 v 22:14 Amador Pahim napsal(a): > On Thu, Jul 20, 2017 at 7:49 PM, Eduardo Habkost wrote: >> On Thu, Jul 20, 2017 at 05:09:11PM +0200, Markus Armbruster wrote: >>> Amador Pahim writes: >>> On Thu, Jul 20, 2017 at 1:49 PM, Markus Armbruster wrote: > Amador Pahim writ

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Amador Pahim
On Thu, Jul 20, 2017 at 7:49 PM, Eduardo Habkost wrote: > On Thu, Jul 20, 2017 at 05:09:11PM +0200, Markus Armbruster wrote: >> Amador Pahim writes: >> >> > On Thu, Jul 20, 2017 at 1:49 PM, Markus Armbruster >> > wrote: >> >> Amador Pahim writes: >> >> >> >>> Current implementation is broken.

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Eduardo Habkost
On Thu, Jul 20, 2017 at 05:09:11PM +0200, Markus Armbruster wrote: > Amador Pahim writes: > > > On Thu, Jul 20, 2017 at 1:49 PM, Markus Armbruster > > wrote: > >> Amador Pahim writes: > >> > >>> Current implementation is broken. It does not really test if the child > >>> process is running. >

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Amador Pahim
On Thu, Jul 20, 2017 at 5:09 PM, Markus Armbruster wrote: > Amador Pahim writes: > >> On Thu, Jul 20, 2017 at 1:49 PM, Markus Armbruster wrote: >>> Amador Pahim writes: >>> Current implementation is broken. It does not really test if the child process is running. >>> >>> What usage ex

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Markus Armbruster
Amador Pahim writes: > On Thu, Jul 20, 2017 at 1:49 PM, Markus Armbruster wrote: >> Amador Pahim writes: >> >>> Current implementation is broken. It does not really test if the child >>> process is running. >> >> What usage exactly is broken by this? Got a reproducer for me? > > Problem is tha

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Amador Pahim
On Thu, Jul 20, 2017 at 1:49 PM, Markus Armbruster wrote: > Amador Pahim writes: > >> Current implementation is broken. It does not really test if the child >> process is running. > > What usage exactly is broken by this? Got a reproducer for me? Problem is that 'returncode' is not set without

Re: [Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Markus Armbruster
Amador Pahim writes: > Current implementation is broken. It does not really test if the child > process is running. What usage exactly is broken by this? Got a reproducer for me? > The Popen.returncode will only be set after by a poll(), wait() or > communicate(). If the Popen fails to launch

[Qemu-devel] [PATCH v3 1/3] qemu.py: fix is_running()

2017-07-20 Thread Amador Pahim
Current implementation is broken. It does not really test if the child process is running. The Popen.returncode will only be set after by a poll(), wait() or communicate(). If the Popen fails to launch a VM, the Popen.returncode will not turn to None by itself. Instead of using Popen.returncode,