Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-23 Thread David Hildenbrand
On 22.04.2018 12:10, David Gibson wrote: > On Sun, Apr 22, 2018 at 10:21:34AM +0200, David Hildenbrand wrote: >> On 22.04.2018 06:26, David Gibson wrote: >>> On Fri, Apr 20, 2018 at 02:34:54PM +0200, David Hildenbrand wrote: On the qmp level, we already have the concept of memory devices:

Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-22 Thread David Gibson
On Sun, Apr 22, 2018 at 10:21:34AM +0200, David Hildenbrand wrote: > On 22.04.2018 06:26, David Gibson wrote: > > On Fri, Apr 20, 2018 at 02:34:54PM +0200, David Hildenbrand wrote: > >> On the qmp level, we already have the concept of memory devices: > >> "query-memory-devices" > >> Right now,

Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-22 Thread David Hildenbrand
>> +typedef struct MemoryDeviceClass { >> +InterfaceClass parent_class; >> + >> +uint64_t (*get_addr)(MemoryDeviceState *md); >> +uint64_t (*get_plugged_size)(MemoryDeviceState *md, Error **errp); >> +uint64_t (*get_region_size)(MemoryDeviceState *md, Error **errp); > > Just not su

Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-22 Thread David Hildenbrand
On 22.04.2018 06:26, David Gibson wrote: > On Fri, Apr 20, 2018 at 02:34:54PM +0200, David Hildenbrand wrote: >> On the qmp level, we already have the concept of memory devices: >> "query-memory-devices" >> Right now, we only support NVDIMM and PCDIMM. >> >> We want to map other devices later i

Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-21 Thread Pankaj Gupta
> > On the qmp level, we already have the concept of memory devices: > "query-memory-devices" > Right now, we only support NVDIMM and PCDIMM. > > We want to map other devices later into the address space of the guest. > Such device could e.g. be virtio devices. These devices will have a > gu

Re: [Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-21 Thread David Gibson
On Fri, Apr 20, 2018 at 02:34:54PM +0200, David Hildenbrand wrote: > On the qmp level, we already have the concept of memory devices: > "query-memory-devices" > Right now, we only support NVDIMM and PCDIMM. > > We want to map other devices later into the address space of the guest. > Such devi

[Qemu-devel] [PATCH v3 1/3] pc-dimm: factor out MemoryDevice interface

2018-04-20 Thread David Hildenbrand
On the qmp level, we already have the concept of memory devices: "query-memory-devices" Right now, we only support NVDIMM and PCDIMM. We want to map other devices later into the address space of the guest. Such device could e.g. be virtio devices. These devices will have a guest memory range a