Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-11 Thread Marcel Apfelbaum
On Sun, 2014-03-09 at 20:06 +0200, Michael S. Tsirkin wrote: > we put copy of ROMs in MR for migration. > but the name rom_in_ram makes one think we > load it in guest RAM. > Rename has_mr to make intent clearer. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/loader.h | 2 +- > hw/core

Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-11 Thread Michael S. Tsirkin
On Mon, Mar 10, 2014 at 09:58:54AM +0100, Paolo Bonzini wrote: > Il 09/03/2014 19:06, Michael S. Tsirkin ha scritto: > >we put copy of ROMs in MR for migration. > >but the name rom_in_ram makes one think we > >load it in guest RAM. > >Rename has_mr to make intent clearer. > > > >Signed-off-by: Mich

Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-10 Thread Paolo Bonzini
Il 09/03/2014 19:06, Michael S. Tsirkin ha scritto: we put copy of ROMs in MR for migration. but the name rom_in_ram makes one think we load it in guest RAM. Rename has_mr to make intent clearer. Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 2 +- hw/core/loader.c| 6 +++---

Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-09 Thread Jeff E. Nelson
On 03/09/2014 02:06 PM, Michael S. Tsirkin wrote: we put copy of ROMs in MR for migration. but the name rom_in_ram makes one think we load it in guest RAM. Rename has_mr to make intent clearer. Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 2 +- hw/core/loader.c| 6 +++---

[Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr

2014-03-09 Thread Michael S. Tsirkin
we put copy of ROMs in MR for migration. but the name rom_in_ram makes one think we load it in guest RAM. Rename has_mr to make intent clearer. Signed-off-by: Michael S. Tsirkin --- include/hw/loader.h | 2 +- hw/core/loader.c| 6 +++--- hw/i386/pc_piix.c | 2 +- hw/i386/pc_q35.c| 2 +-