Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable

2019-04-17 Thread Eduardo Habkost
On Wed, Apr 17, 2019 at 07:26:14AM +0200, Markus Armbruster wrote: > Like Xu writes: > > > This patch makes the remaining dozen or so uses of the global > > current_machine outside vl.c use qdev_get_machine() instead, > > and then make current_machine local to vl.c instead of global. > > > > Sugg

Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable

2019-04-16 Thread Markus Armbruster
Like Xu writes: > This patch makes the remaining dozen or so uses of the global > current_machine outside vl.c use qdev_get_machine() instead, > and then make current_machine local to vl.c instead of global. > > Suggested-by: Peter Maydell > Signed-off-by: Like Xu I'm afraid I dislike this one

Re: [Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable

2019-04-16 Thread Eduardo Habkost
On Mon, Apr 15, 2019 at 03:59:44PM +0800, Like Xu wrote: > This patch makes the remaining dozen or so uses of the global > current_machine outside vl.c use qdev_get_machine() instead, > and then make current_machine local to vl.c instead of global. > > Suggested-by: Peter Maydell > Signed-off-by:

[Qemu-devel] [PATCH v3 1/2] vl.c: refactor current_machine as non-global variable

2019-04-15 Thread Like Xu
This patch makes the remaining dozen or so uses of the global current_machine outside vl.c use qdev_get_machine() instead, and then make current_machine local to vl.c instead of global. Suggested-by: Peter Maydell Signed-off-by: Like Xu --- accel/kvm/kvm-all.c | 6 -- device-hotplug.c|