Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-06-05 Thread Halil Pasic
On 06/05/2018 12:14 PM, Cornelia Huck wrote: On Thu, 24 May 2018 19:58:27 +0200 Halil Pasic wrote: There is at least one guest (OS) such that although it does not rely on the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka P bit) not being set, it fails to tell this to

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-06-05 Thread Cornelia Huck
On Thu, 24 May 2018 19:58:27 +0200 Halil Pasic wrote: > There is at least one guest (OS) such that although it does not rely on > the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka > P bit) not being set, it fails to tell this to the machine. > > Usually this ain't a big de

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-25 Thread Halil Pasic
On 05/25/2018 08:08 PM, Eric Blake wrote: On 05/25/2018 12:46 PM, Halil Pasic wrote: +static inline void warn_once(bool *warned, const char *fmt, ...) +{ +    va_list ap; + +    if (!warned || *warned) { +    return; +    } +    *warned = true; +    va_start(ap, fmt); +    warn_vreport(fm

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-25 Thread Eric Blake
On 05/25/2018 12:46 PM, Halil Pasic wrote: +static inline void warn_once(bool *warned, const char *fmt, ...) +{ +    va_list ap; + +    if (!warned || *warned) { +    return; +    } +    *warned = true; +    va_start(ap, fmt); +    warn_vreport(fmt, ap); +    va_end(ap); +} + +static inline

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-25 Thread Halil Pasic
On 05/25/2018 11:40 AM, Cornelia Huck wrote: On Thu, 24 May 2018 19:58:27 +0200 Halil Pasic wrote: There is at least one guest (OS) such that although it does not rely on the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka P bit) not being set, it fails to tell this to t

Re: [Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-25 Thread Cornelia Huck
On Thu, 24 May 2018 19:58:27 +0200 Halil Pasic wrote: > There is at least one guest (OS) such that although it does not rely on > the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka > P bit) not being set, it fails to tell this to the machine. > > Usually this ain't a big de

[Qemu-devel] [PATCH v3 1/2] vfio-ccw: add force unlimited prefetch property

2018-05-24 Thread Halil Pasic
There is at least one guest (OS) such that although it does not rely on the guarantees provided by ORB 1 word 9 bit (aka unlimited prefetch, aka P bit) not being set, it fails to tell this to the machine. Usually this ain't a big deal, as the original purpose of the P bit is to allow for performan