Re: [Qemu-devel] [PATCH v3 1/2] slirp: Add sanity check for str option length

2018-10-21 Thread Samuel Thibault
Hello, Fam Zheng, le ven. 14 sept. 2018 15:26:15 +0800, a ecrit: > When user provides a long domainname or hostname that doesn't fit in the > DHCP packet, we mustn't overflow the response packet buffer. Instead, > report errors, following the g_warning() in the slirp->vdnssearch > branch. > > Als

[Qemu-devel] [PATCH v3 1/2] slirp: Add sanity check for str option length

2018-09-14 Thread Fam Zheng
When user provides a long domainname or hostname that doesn't fit in the DHCP packet, we mustn't overflow the response packet buffer. Instead, report errors, following the g_warning() in the slirp->vdnssearch branch. Also check the strlen against 256 when initializing slirp, which limit is also fr