Re: [Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-29 Thread Markus Armbruster
Bandan Das writes: > Eric Blake writes: > >> On 05/28/2015 12:48 PM, Bandan Das wrote: >>> Markus Armbruster writes: >>> Bandan Das writes: > There's too much going on in monitor_parse_command(). > Split up the arguments parsing bits into a separate function > monitor_pa

Re: [Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-28 Thread Bandan Das
Eric Blake writes: > On 05/28/2015 12:48 PM, Bandan Das wrote: >> Markus Armbruster writes: >> >>> Bandan Das writes: >>> There's too much going on in monitor_parse_command(). Split up the arguments parsing bits into a separate function monitor_parse_arguments(). Let the origina

Re: [Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-28 Thread Eric Blake
On 05/28/2015 12:48 PM, Bandan Das wrote: > Markus Armbruster writes: > >> Bandan Das writes: >> >>> There's too much going on in monitor_parse_command(). >>> Split up the arguments parsing bits into a separate function >>> monitor_parse_arguments(). Let the original function check for >>> comma

Re: [Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-28 Thread Bandan Das
Markus Armbruster writes: > Bandan Das writes: > >> There's too much going on in monitor_parse_command(). >> Split up the arguments parsing bits into a separate function >> monitor_parse_arguments(). Let the original function check for >> command validity and sub-commands if any and return data

Re: [Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-28 Thread Markus Armbruster
Bandan Das writes: > There's too much going on in monitor_parse_command(). > Split up the arguments parsing bits into a separate function > monitor_parse_arguments(). Let the original function check for > command validity and sub-commands if any and return data (*cmd) > that the newly introduced

[Qemu-devel] [PATCH v3 1/2] monitor: cleanup parsing of cmd name and cmd arguments

2015-05-27 Thread Bandan Das
There's too much going on in monitor_parse_command(). Split up the arguments parsing bits into a separate function monitor_parse_arguments(). Let the original function check for command validity and sub-commands if any and return data (*cmd) that the newly introduced function can process and return