Re: [Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-19 Thread Laszlo Ersek
On 08/19/13 13:18, Michael S. Tsirkin wrote: > On Mon, Aug 19, 2013 at 01:09:36PM +0200, Laszlo Ersek wrote: >> On 08/19/13 12:21, Peter Maydell wrote: >>> On 19 August 2013 10:59, Laszlo Ersek wrote: On 08/13/13 00:43, Michael S. Tsirkin wrote: > Migration code assumes that each RAM bloc

Re: [Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 01:09:36PM +0200, Laszlo Ersek wrote: > On 08/19/13 12:21, Peter Maydell wrote: > > On 19 August 2013 10:59, Laszlo Ersek wrote: > >> On 08/13/13 00:43, Michael S. Tsirkin wrote: > >>> Migration code assumes that each RAM block is a multiple of target page > >>> size. > >>

Re: [Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-19 Thread Laszlo Ersek
On 08/19/13 12:21, Peter Maydell wrote: > On 19 August 2013 10:59, Laszlo Ersek wrote: >> On 08/13/13 00:43, Michael S. Tsirkin wrote: >>> Migration code assumes that each RAM block is a multiple of target page >>> size. >> >> Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macr

Re: [Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-19 Thread Michael S. Tsirkin
On Mon, Aug 19, 2013 at 11:59:25AM +0200, Laszlo Ersek wrote: > On 08/13/13 00:43, Michael S. Tsirkin wrote: > > Migration code assumes that each RAM block is a multiple of target page > > size. > > Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro > call in qemu_ram_alloc_f

Re: [Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-19 Thread Peter Maydell
On 19 August 2013 10:59, Laszlo Ersek wrote: > On 08/13/13 00:43, Michael S. Tsirkin wrote: >> Migration code assumes that each RAM block is a multiple of target page >> size. > > Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro > call in qemu_ram_alloc_from_ptr() [exec.c]?

Re: [Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-19 Thread Laszlo Ersek
On 08/13/13 00:43, Michael S. Tsirkin wrote: > Migration code assumes that each RAM block is a multiple of target page > size. Isn't that a valid assumption, considering the TARGET_PAGE_ALIGN() macro call in qemu_ram_alloc_from_ptr() [exec.c]? > We can fix this in a variety of ways, the simplest

[Qemu-devel] [PATCH v3 1/2] memory: export migration page size

2013-08-12 Thread Michael S. Tsirkin
Migration code assumes that each RAM block is a multiple of target page size. We can fix this in a variety of ways, the simplest way is exporting the required page size so callers can make regions large enough. Signed-off-by: Michael S. Tsirkin --- arch_init.c | 6 ++ include/exec/