Re: [Qemu-devel] [PATCH v3 1/2] block: allow live commit of active image

2013-09-18 Thread Paolo Bonzini
Il 04/09/2013 14:35, Stefan Hajnoczi ha scritto: > Changing from 512 KB to 64 KB can affect performance. 8 times as many > iops may be issued to copy data. > > Also, the image's cluster size should really be taken into account. > Otherwise additional inefficiency will be suffered when we populate

Re: [Qemu-devel] [PATCH v3 1/2] block: allow live commit of active image

2013-09-18 Thread Stefan Hajnoczi
On Wed, Sep 18, 2013 at 11:32:31AM +0800, Fam Zheng wrote: > On Wed, 09/04 14:35, Stefan Hajnoczi wrote: > > On Thu, Aug 15, 2013 at 04:14:06PM +0800, Fam Zheng wrote: > > > diff --git a/block/commit.c b/block/commit.c > > > index 2227fc2..b5e024b 100644 > > > --- a/block/commit.c > > > +++ b/block

Re: [Qemu-devel] [PATCH v3 1/2] block: allow live commit of active image

2013-09-17 Thread Fam Zheng
On Wed, 09/04 14:35, Stefan Hajnoczi wrote: > On Thu, Aug 15, 2013 at 04:14:06PM +0800, Fam Zheng wrote: > > diff --git a/block/commit.c b/block/commit.c > > index 2227fc2..b5e024b 100644 > > --- a/block/commit.c > > +++ b/block/commit.c > > @@ -17,14 +17,13 @@ > > #include "block/blockjob.h" > >

Re: [Qemu-devel] [PATCH v3 1/2] block: allow live commit of active image

2013-09-04 Thread Stefan Hajnoczi
On Thu, Aug 15, 2013 at 04:14:06PM +0800, Fam Zheng wrote: > diff --git a/block/commit.c b/block/commit.c > index 2227fc2..b5e024b 100644 > --- a/block/commit.c > +++ b/block/commit.c > @@ -17,14 +17,13 @@ > #include "block/blockjob.h" > #include "qemu/ratelimit.h" > > -enum { > -/* > -

[Qemu-devel] [PATCH v3 1/2] block: allow live commit of active image

2013-08-15 Thread Fam Zheng
This patch eliminates limitation of committing the active device. bdrv_drop_intermediate is reimplemented to take pointers to (BlockDriverState *), so it can modify the caller's local pointers to preserve their semantics, while updating active BDS in-place by bdrv_swap active and base: we need dat