Re: [Qemu-devel] [PATCH v3 1/2] bitops: drop volatile qualifier

2012-07-23 Thread Blue Swirl
On Mon, Jul 16, 2012 at 2:40 PM, Eric Blake wrote: > On 07/14/2012 06:34 AM, Blue Swirl wrote: >> Qualifier 'volatile' is not useful for applications, it's too strict >> for single threaded code but does not give the real atomicity guarantees >> needed for multithreaded code. >> >> Drop them and n

Re: [Qemu-devel] [PATCH v3 1/2] bitops: drop volatile qualifier

2012-07-16 Thread Eric Blake
On 07/14/2012 06:34 AM, Blue Swirl wrote: > Qualifier 'volatile' is not useful for applications, it's too strict > for single threaded code but does not give the real atomicity guarantees > needed for multithreaded code. > > Drop them and now useless casts. > > -static inline void set_bit(int nr

Re: [Qemu-devel] [PATCH v3 1/2] bitops: drop volatile qualifier

2012-07-14 Thread Peter Maydell
On 14 July 2012 13:34, Blue Swirl wrote: > Qualifier 'volatile' is not useful for applications, it's too strict > for single threaded code but does not give the real atomicity guarantees > needed for multithreaded code. > > Drop them and now useless casts. > > Signed-off-by: Blue Swirl Reviewed-

[Qemu-devel] [PATCH v3 1/2] bitops: drop volatile qualifier

2012-07-14 Thread Blue Swirl
Qualifier 'volatile' is not useful for applications, it's too strict for single threaded code but does not give the real atomicity guarantees needed for multithreaded code. Drop them and now useless casts. Signed-off-by: Blue Swirl --- bitops.h | 26 +- 1 files changed