Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-07-07 Thread Eduardo Habkost
Hi, Sorry for taking so long to review it. The patch in general looks good, except for: On Fri, Jun 24, 2016 at 01:49:36PM +0300, Denis V. Lunev wrote: [...] > +if (MACHINE_GET_CLASS(current_machine)->hot_add_cpu != NULL) { > +env->features[FEAT_HYPERV_EDX] |= > HV_X64_CPU_DYNAMIC_P

Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-07-05 Thread Denis V. Lunev
On 06/24/2016 01:49 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through qom request. Currently qem

Re: [Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-06-30 Thread Denis V. Lunev
On 06/24/2016 01:49 PM, Denis V. Lunev wrote: From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through qom request. Currently qem

[Qemu-devel] [PATCH v3 1/1] cpu: report hyperv feature words through qom

2016-06-24 Thread Denis V. Lunev
From: Evgeny Yakovlev This change adds hyperv feature words report through qom rpc. When VM is configured with hyperv features enabled libvirt will check that required feature words are set in cpuid leaf 4003 through qom request. Currently qemu does not report hyperv feature words which pre