Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-12 Thread David Gibson
On Wed, Aug 07, 2019 at 05:01:42PM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 07:33, David Gibson > wrote: > > > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > > Signed-off-by: Damien Hedde > > > +For Devices and Buses there is also the corresponding helpers: > > >

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-08 Thread David Gibson
On Wed, Aug 07, 2019 at 11:34:41AM +0100, Peter Maydell wrote: > On Wed, 31 Jul 2019 at 07:33, David Gibson > wrote: > > > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > > +The function *resettable_reset* is used to trigger a reset on a given > > > +object. > > > +void resett

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-07 Thread Peter Maydell
On Wed, 31 Jul 2019 at 07:33, David Gibson wrote: > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > Signed-off-by: Damien Hedde > > +For Devices and Buses there is also the corresponding helpers: > > +void device_reset(Device *dev, bool cold) > > +void bus_reset(Device *dev, b

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > +For Devices and Buses there is also the corresponding helpers: > +void device_reset(Device *dev, bool cold) > +void bus_reset(Device *dev, bool cold Just noticed, but the prototype here is wrong: bus_reset() takes a BusState*, not a Device*.

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-07 Thread Peter Maydell
On Mon, 29 Jul 2019 at 15:59, Damien Hedde wrote: > > Signed-off-by: Damien Hedde > --- > docs/devel/reset.txt | 165 +++ > 1 file changed, 165 insertions(+) > create mode 100644 docs/devel/reset.txt > > diff --git a/docs/devel/reset.txt b/docs/devel/rese

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-08-07 Thread Peter Maydell
On Wed, 31 Jul 2019 at 07:33, David Gibson wrote: > > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > > +The function *resettable_reset* is used to trigger a reset on a given > > +object. > > +void resettable_reset(Object *obj, bool cold) > > + > > +The parameter *obj* must impleme

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-07-31 Thread Damien Hedde
On 7/31/19 8:30 AM, David Gibson wrote: > On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: >> Signed-off-by: Damien Hedde >> --- >> docs/devel/reset.txt | 165 +++ >> 1 file changed, 165 insertions(+) >> create mode 100644 docs/devel/reset.

Re: [Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-07-30 Thread David Gibson
On Mon, Jul 29, 2019 at 04:56:30PM +0200, Damien Hedde wrote: > Signed-off-by: Damien Hedde > --- > docs/devel/reset.txt | 165 +++ > 1 file changed, 165 insertions(+) > create mode 100644 docs/devel/reset.txt > > diff --git a/docs/devel/reset.txt b/docs/

[Qemu-devel] [PATCH v3 09/33] add doc about Resettable interface

2019-07-29 Thread Damien Hedde
Signed-off-by: Damien Hedde --- docs/devel/reset.txt | 165 +++ 1 file changed, 165 insertions(+) create mode 100644 docs/devel/reset.txt diff --git a/docs/devel/reset.txt b/docs/devel/reset.txt new file mode 100644 index 00..c7a1eb068f --- /dev/n