Re: [Qemu-devel] [PATCH v3 09/10] vmdk: use heap allocation for whole_grain

2013-08-05 Thread Jeff Cody
On Tue, Aug 06, 2013 at 09:40:42AM +0800, Fam Zheng wrote: > We should never grow the stack beyond 1 MB, otherwise we'll fall off the > end. Thread stacks and coroutine stacks (1 MB) do not grow. > get_cluster_offset() allocates a big stack offset, it will fail for big > cluster images, change to

[Qemu-devel] [PATCH v3 09/10] vmdk: use heap allocation for whole_grain

2013-08-05 Thread Fam Zheng
We should never grow the stack beyond 1 MB, otherwise we'll fall off the end. Thread stacks and coroutine stacks (1 MB) do not grow. get_cluster_offset() allocates a big stack offset, it will fail for big cluster images, change to heap allocated buffer. Signed-off-by: Fam Zheng --- block/vmdk.c