Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Jia Liu
Hi Andreas, I'll read your patch and try to catch your step. Thank you very much for reviewing and comments, you make me open my eyes on QEMU. On Fri, Jun 8, 2012 at 9:31 PM, Andreas Färber wrote: > Am 08.06.2012 15:28, schrieb Andreas Färber: >> Am 08.06.2012 14:56, schrieb Max Filippov: >>> On

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Jia Liu
Hi Max, On Fri, Jun 8, 2012 at 8:56 PM, Max Filippov wrote: > Hi Jia. > > On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: > > [...] > +    case 0x0009: +        switch (op1) { +        case 0x03:   /*l.div*/ +            LOG_DIS("l.div r%d, r%d, r%d\n", rd, ra, rb); +    

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Andreas Färber
Am 08.06.2012 15:28, schrieb Andreas Färber: > Am 08.06.2012 14:56, schrieb Max Filippov: >> On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: >> >>>{ >>>TCGv_i64 t0 = tcg_temp_new(); >>>TCGv_i64 t1 = tcg_temp_new(); >>>TCGv_i64 t2 = tcg_temp_new(); >>>

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Andreas Färber
Am 08.06.2012 14:56, schrieb Max Filippov: > On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: > >>{ >>TCGv_i64 t0 = tcg_temp_new(); >>TCGv_i64 t1 = tcg_temp_new(); >>TCGv_i64 t2 = tcg_temp_new(); >>tcg_gen_mul_tl(t0, cpu_R[ra], cpu_R[rb]); >

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-08 Thread Max Filippov
Hi Jia. On Fri, Jun 8, 2012 at 4:00 AM, Jia Liu wrote: [...] >>> +    case 0x0009: >>> +        switch (op1) { >>> +        case 0x03:   /*l.div*/ >>> +            LOG_DIS("l.div r%d, r%d, r%d\n", rd, ra, rb); >>> +            { >>> +                TCGv_i32 sr_ove; >>> +                int lab

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-07 Thread Wei-Ren Chen
On Thu, Jun 07, 2012 at 05:21:04PM -0700, Richard Henderson wrote: > On 2012-06-07 17:00, Jia Liu wrote: > > TCGv_i32 sr_ove = tcg_temp_new_i32(); > > You need tcg_temp_local_new_i32 in order to last beyond the branches. > > Frankly, it's often easier to handle division and its ex

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-07 Thread Jia Liu
Hi Richard, On Fri, Jun 8, 2012 at 8:21 AM, Richard Henderson wrote: > On 2012-06-07 17:00, Jia Liu wrote: >>                 TCGv_i32 sr_ove = tcg_temp_new_i32(); > > You need tcg_temp_local_new_i32 in order to last beyond the branches. > > Frankly, it's often easier to handle division and its e

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-07 Thread Richard Henderson
On 2012-06-07 17:00, Jia Liu wrote: > TCGv_i32 sr_ove = tcg_temp_new_i32(); You need tcg_temp_local_new_i32 in order to last beyond the branches. Frankly, it's often easier to handle division and its exceptions via an out-of-line handler. r~

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-07 Thread Jia Liu
Hi Max, Thank you for your unaided eye look :-) I've fixed them, and, I think, it will be good if you check them before I make V4 pacthes. So, please, use your unaided eye again. On Thu, Jun 7, 2012 at 12:40 AM, Max Filippov wrote: > Hi Jia, > > more comments on remaining issues visible with un

Re: [Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-06 Thread Max Filippov
Hi Jia, more comments on remaining issues visible with unaided eye. On Wed, Jun 6, 2012 at 4:27 PM, Jia Liu wrote: > Add OpenRISC translation routines. > > Signed-off-by: Jia Liu > --- [...] > +    case 0x0009: > +        switch (op1) { > +        case 0x03:   /*l.div*/ > +            LOG_DIS

[Qemu-devel] [PATCH v3 08/16] target-or32: Add translation routines

2012-06-06 Thread Jia Liu
Add OpenRISC translation routines. Signed-off-by: Jia Liu --- target-openrisc/translate.c | 1440 +++ 1 file changed, 1440 insertions(+) diff --git a/target-openrisc/translate.c b/target-openrisc/translate.c index 61fb1cf..09898e8 100644 --- a/target-open