Re: [Qemu-devel] [PATCH v3 08/13] sm501: Fix hardware cursor

2017-03-03 Thread Peter Maydell
On 4 December 2016 at 18:01, BALATON Zoltan wrote: > Signed-off-by: BALATON Zoltan > --- > > v3: simplify return expression in get_bpp In my review on v2 I asked for the commit message to say clearly what the bugs being fixed here are. It's a lot easier to review a patch if I know what it's supp

[Qemu-devel] [PATCH v3 08/13] sm501: Fix hardware cursor

2017-03-02 Thread BALATON Zoltan
Signed-off-by: BALATON Zoltan --- v3: simplify return expression in get_bpp hw/display/sm501.c | 169 +--- hw/display/sm501_template.h | 25 +++ 2 files changed, 107 insertions(+), 87 deletions(-) diff --git a/hw/display/sm501.c b/hw/displa