Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-08 Thread Xiao Guangrong
On 08/08/2018 10:11 PM, Dr. David Alan Gilbert wrote: * Xiao Guangrong (guangrong.x...@gmail.com) wrote: On 08/08/2018 01:08 PM, Peter Xu wrote: On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong ram_find_and_save_block() can return negative i

Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-08 Thread Dr. David Alan Gilbert
* Xiao Guangrong (guangrong.x...@gmail.com) wrote: > > > On 08/08/2018 01:08 PM, Peter Xu wrote: > > On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > ram_find_and_save_block() can return negative if any error hanppens, > > > howeve

Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-08 Thread Peter Xu
On Wed, Aug 08, 2018 at 03:23:22PM +0800, Xiao Guangrong wrote: > > > On 08/08/2018 02:56 PM, Peter Xu wrote: > > On Wed, Aug 08, 2018 at 02:29:52PM +0800, Xiao Guangrong wrote: > > > > > > > > > On 08/08/2018 01:08 PM, Peter Xu wrote: > > > > On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong

Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-08 Thread Xiao Guangrong
On 08/08/2018 02:56 PM, Peter Xu wrote: On Wed, Aug 08, 2018 at 02:29:52PM +0800, Xiao Guangrong wrote: On 08/08/2018 01:08 PM, Peter Xu wrote: On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong ram_find_and_save_block() can return negative if

Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-07 Thread Peter Xu
On Wed, Aug 08, 2018 at 02:29:52PM +0800, Xiao Guangrong wrote: > > > On 08/08/2018 01:08 PM, Peter Xu wrote: > > On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong.x...@gmail.com wrote: > > > From: Xiao Guangrong > > > > > > ram_find_and_save_block() can return negative if any error hanppens,

Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-07 Thread Xiao Guangrong
On 08/08/2018 01:08 PM, Peter Xu wrote: On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong.x...@gmail.com wrote: From: Xiao Guangrong ram_find_and_save_block() can return negative if any error hanppens, however, it is completely ignored in current code Could you hint me where we'll retur

Re: [Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-07 Thread Peter Xu
On Tue, Aug 07, 2018 at 05:12:07PM +0800, guangrong.x...@gmail.com wrote: > From: Xiao Guangrong > > ram_find_and_save_block() can return negative if any error hanppens, > however, it is completely ignored in current code Could you hint me where we'll return an error? (Anyway I agree that the e

[Qemu-devel] [PATCH v3 08/10] migration: handle the error condition properly

2018-08-07 Thread guangrong . xiao
From: Xiao Guangrong ram_find_and_save_block() can return negative if any error hanppens, however, it is completely ignored in current code Signed-off-by: Xiao Guangrong --- migration/ram.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/migration/ram.c