Re: [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-12-16 Thread Alberto Garcia
On Fri 16 Dec 2016 02:26:29 PM CET, Max Reitz wrote: >>> int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, >>> const char *bdref_key, Error **errp) >>> { >>> -char *backing_filename = g_malloc0(PATH_MAX); >>> +char *backing_filename = NUL

Re: [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-12-16 Thread Max Reitz
On 15.12.2016 17:39, Alberto Garcia wrote: > On Wed 30 Nov 2016 02:18:33 AM CET, Max Reitz wrote: >> int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, >> const char *bdref_key, Error **errp) >> { >> -char *backing_filename = g_malloc0(PATH_MAX

Re: [Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-12-15 Thread Alberto Garcia
On Wed 30 Nov 2016 02:18:33 AM CET, Max Reitz wrote: > int bdrv_open_backing_file(BlockDriverState *bs, QDict *parent_options, > const char *bdref_key, Error **errp) > { > -char *backing_filename = g_malloc0(PATH_MAX); > +char *backing_filename = NULL; > c

[Qemu-devel] [PATCH v3 07/25] block: bdrv_get_full_backing_filename's ret. val.

2016-11-29 Thread Max Reitz
Make bdrv_get_full_backing_filename() return an allocated string instead of placing the result in a caller-provided buffer. Signed-off-by: Max Reitz --- block.c | 26 +- block/qapi.c | 12 ++-- include/block/block.h | 3 +-- 3 files changed